Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

III-4866 refactor EditPlaceRestController to 2 handlers-1/2-updateAddress() #1101

Merged
merged 15 commits into from
Aug 24, 2022
Merged

III-4866 refactor EditPlaceRestController to 2 handlers-1/2-updateAddress() #1101

merged 15 commits into from
Aug 24, 2022

Conversation

JonasVHG
Copy link
Contributor

@JonasVHG JonasVHG commented Aug 22, 2022 •
edited
Loading

Added

  • RequestHandler for updateAddress() & tests
  • test for new RequestHandler

Changed

  • make PlaceControllerProvider use RequestHandler for updateAddress()
  • replace usages of DefaultPlaceEditingService with DefaultOfferEditingService

Removed

  • remove updateAddress() & placeContext() from EditPlaceRestController
  • remove updateAddress() from PlaceEditingServiceInterface
  • remove DefaultPlaceEditingService & tests
  • tests for EditPlaceRestController

Ticket: https://jira.uitdatabank.be/browse/III-4866

@JonasVHG JonasVHG changed the title III-4866 refactor edit place rest controller into 2 handlers update address III-4866 refactor EditPlaceRestController to 2 handlers-1/2-updateAddress() Aug 22, 2022
@JonasVHG JonasVHG changed the title III-4866 refactor EditPlaceRestController to 2 handlers-1/2-updateAddress() III-4866 refactor EditPlaceRestController to 2 handlers-1/2-updateAddress() Aug 22, 2022
@JonasVHG JonasVHG changed the title III-4866 refactor EditPlaceRestController to 2 handlers-1/2-updateAddress() III-4866 refactor EditPlaceRestController to 2 handlers-1/2-updateAddress() Aug 22, 2022
@JonasVHG JonasVHG marked this pull request as ready for review August 23, 2022 07:30
bertramakers
bertramakers approved these changes Aug 23, 2022
View reviewed changes
Copy link
Contributor

@bertramakers bertramakers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! 👍

src/Http/Place/UpdateAddressRequestHandler.php Outdated Show resolved Hide resolved
src/Place/DefaultPlaceEditingService.php Show resolved Hide resolved
LucWollants
LucWollants approved these changes Aug 23, 2022
View reviewed changes
Copy link
Contributor

@LucWollants LucWollants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I already approved because my remarks are minor.

@JonasVHG JonasVHG merged commit 90d5bbb into master Aug 24, 2022
@JonasVHG JonasVHG deleted the feature/III-4866-refactor-EditPlaceRestController-into-2-handlers-updateAddress branch August 24, 2022 07:34
@bertramakers bertramakers mentioned this pull request Aug 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bertramakers bertramakers bertramakers approved these changes

@LucWollants LucWollants LucWollants approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JonasVHG @bertramakers @LucWollants