Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port the project to C++11 - Part 2 #72

Merged
merged 12 commits into from
Sep 26, 2022
Merged

Port the project to C++11 - Part 2 #72

merged 12 commits into from
Sep 26, 2022

Commits on Sep 26, 2022

  1. abstract-parser: drop dynamic_cast in favour of AbstractParser::input… 

    …Format
    @lzaoral
    lzaoral committed Sep 26, 2022
    Configuration menu
    Copy the full SHA
    5cc2dbd View commit details
    Browse the repository at this point in the history

  2. color: mark constant methods const

    @lzaoral
    lzaoral committed Sep 26, 2022
    Configuration menu
    Copy the full SHA
    2fe057f View commit details
    Browse the repository at this point in the history

  3. csdiff: use using instead of typedef

    @lzaoral
    lzaoral committed Sep 26, 2022
    Configuration menu
    Copy the full SHA
    1e7db3c View commit details
    Browse the repository at this point in the history

  4. csdiff: fix typos

    @lzaoral
    lzaoral committed Sep 26, 2022
    Configuration menu
    Copy the full SHA
    3953d31 View commit details
    Browse the repository at this point in the history

  5. csfilter: use using instead of typedef

    @lzaoral
    lzaoral committed Sep 26, 2022
    Configuration menu
    Copy the full SHA
    7964574 View commit details
    Browse the repository at this point in the history

  6. instream: use == instead of !s1.compare(s2)

    @lzaoral
    lzaoral committed Sep 26, 2022
    Configuration menu
    Copy the full SHA
    b39d716 View commit details
    Browse the repository at this point in the history

  7. instream: use std::ifstream instead of more generic std::fstream 

    * The constructor call is more succinct.
    @lzaoral
    lzaoral committed Sep 26, 2022
    Configuration menu
    Copy the full SHA
    87082d1 View commit details
    Browse the repository at this point in the history

  8. instream: use defaulted default destructor 

    There is no point in closing std::ifstream in a destructor manually since
that will be done either way in its own destructor.
    @lzaoral
    lzaoral committed Sep 26, 2022
    Configuration menu
    Copy the full SHA
    cd9e94b View commit details
    Browse the repository at this point in the history

  9. instream: change type of line in handleError to unsigned long 

    ... because negative line number does not make any sense and
boost::file_parser_error::line also returns unsigned long.and pass msg by
a const reference.
    @lzaoral
    lzaoral committed Sep 26, 2022
    Configuration menu
    Copy the full SHA
    80ea97f View commit details
    Browse the repository at this point in the history

  10. instream: pass std::string by value and then move it in constructors 

    ... to avoid excessively copies of std::string rvalues.
    @lzaoral
    lzaoral committed Sep 26, 2022
    Configuration menu
    Copy the full SHA
    4c1ec90 View commit details
    Browse the repository at this point in the history

  11. instream: use default member initializers for literals

    @lzaoral
    lzaoral committed Sep 26, 2022
    Configuration menu
    Copy the full SHA
    7472caf View commit details
    Browse the repository at this point in the history

  12. instream: make argument identifiers of InStreamLookAhead consistent 

    ... between declaration and definition.
    @lzaoral
    lzaoral committed Sep 26, 2022
    Configuration menu
    Copy the full SHA
    d939290 View commit details
    Browse the repository at this point in the history