Port the project to C++11 - Part 2 #72
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdudka
requested changes
Aug 4, 2022
* The constructor call is more succinct.
There is no point in closing std::ifstream in a destructor manually since that will be done either way in its own destructor.
... because negative line number does not make any sense and boost::file_parser_error::line also returns unsigned long.and pass msg by a const reference.
... to avoid excessively copies of std::string rvalues.
... between declaration and definition.
lzaoral
force-pushed
the
c++11-part2
branch
from
cb72134 to
d939290
Compare
|
Thanks for the review, @kdudka! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit messages.