Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packaging: create symlinks for clang/clang++ #43

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

kdudka
Copy link
Member

@kdudka kdudka commented Jul 16, 2024

... so that we can instrument builds that use Clang as the system compiler.

@kdudka kdudka requested a review from siteshwar July 16, 2024 15:35
@kdudka kdudka self-assigned this Jul 16, 2024
... so that we can instrument builds that use Clang as the system
compiler.

Closes: csutils#43
@kdudka
Copy link
Member Author

kdudka commented Jul 18, 2024

@siteshwar Thanks for review!

@kdudka kdudka closed this in 983b895 Jul 18, 2024
@kdudka kdudka merged commit 983b895 into csutils:main Jul 18, 2024
26 checks passed
@kdudka kdudka deleted the wrap-clang branch July 18, 2024 13:02
kdudka added a commit to kdudka/cscppc that referenced this pull request Jul 19, 2024
We want to hook `gcc -fanalyzer` on `clang` if `clang` is used as the
system compiler.  However, it does not make sense to hook GCC Analyzer
on `clang --analyze`, which is invoked by `csclng` while wrapping `gcc`
as the system compiler.

Apart from wasting resources by running multiple processes of GCC
Analyzer in parallel, this was causing unnecessary noise in `scan.log`
as GCC Analyzer complained about unsupported flags, which were injected
by `csclng` for `clang --analyze` only:
```
gcc: error: unrecognized command-line option ‘-fno-caret-diagnostics’
gcc: error: unrecognized command-line option ‘-fno-caret-diagnostics’
gcc: error: unrecognized command-line option ‘-fno-caret-diagnostics’
```

Reported-by: Lukáš Zaoral
Fixes: commit 983b895
Related: csutils#43
Closes: csutils#44
kdudka added a commit to kdudka/cscppc that referenced this pull request Jul 22, 2024
We want to hook `gcc -fanalyzer` on `clang` if `clang` is used as the
system compiler.  However, it does not make sense to hook GCC Analyzer
on `clang --analyze`, which is invoked by `csclng` while wrapping `gcc`
as the system compiler.

Apart from wasting resources by running multiple processes of GCC
Analyzer in parallel, this was causing unnecessary noise in `scan.log`
as GCC Analyzer complained about unsupported flags, which were injected
by `csclng` for `clang --analyze` only:
```
gcc: error: unrecognized command-line option ‘-fno-caret-diagnostics’
gcc: error: unrecognized command-line option ‘-fno-caret-diagnostics’
gcc: error: unrecognized command-line option ‘-fno-caret-diagnostics’
```

Reported-by: Lukáš Zaoral
Fixes: commit 983b895
Related: csutils#43
Closes: csutils#44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants