cswrap-core: skip known wrappers while invoking an analyzer #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lzaoral
approved these changes
Jul 22, 2024
We want to hook `gcc -fanalyzer` on `clang` if `clang` is used as the system compiler. However, it does not make sense to hook GCC Analyzer on `clang --analyze`, which is invoked by `csclng` while wrapping `gcc` as the system compiler. Apart from wasting resources by running multiple processes of GCC Analyzer in parallel, this was causing unnecessary noise in `scan.log` as GCC Analyzer complained about unsupported flags, which were injected by `csclng` for `clang --analyze` only: ``` gcc: error: unrecognized command-line option ‘-fno-caret-diagnostics’ gcc: error: unrecognized command-line option ‘-fno-caret-diagnostics’ gcc: error: unrecognized command-line option ‘-fno-caret-diagnostics’ ``` Reported-by: Lukáš Zaoral Fixes: commit 983b895 Related: csutils#43 Closes: csutils#44
lzaoral
approved these changes
Jul 23, 2024
|
@lzaoral Thanks for review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to hook
gcc -fanalyzeronclangifclangis used as the system compiler. However, it does not make sense to hook GCC Analyzer onclang --analyze, which is invoked bycsclngwhile wrappinggccas the system compiler.Apart from wasting resources by running multiple processes of GCC Analyzer in parallel, this was causing unnecessary noise in
scan.logas GCC Analyzer complained about unsupported flags, which were injected bycsclngforclang --analyzeonly:Reported-by: Lukáš Zaoral
Fixes: commit 983b895
Related: #43
Closes: #44