Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX for #7: Address nested slot issues and more #18

Closed
wants to merge 2 commits into from
Closed

FIX for #7: Address nested slot issues and more #18

wants to merge 2 commits into from

Commits on Jun 5, 2023

  1. Fix for #12 (take 2): Ensure original named slot tags are retained wh… 

    …en not using shadow root. Take 2 required to account for new unit testing framework (Vitest) from PR #14.
    @patricknelson
    patricknelson committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    5fee97d View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2023

  1. WIP 🚨: Addressing issues with nested slots: 1.) Ensure properly selec… 

    …ting own slots and not that of descendants and 2.) Ensure we're setting up and tearing down state on connect/disconnect, necessary when nested elements render from inside out.
    @patricknelson
    patricknelson committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    8f42f19 View commit details
    Browse the repository at this point in the history