FIX for #7: Address nested slot issues and more #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en not using shadow root. Take 2 required to account for new unit testing framework (Vitest) from PR #14.
…ting own slots and not that of descendants and 2.) Ensure we're setting up and tearing down state on connect/disconnect, necessary when nested elements render from inside out.
patricknelson
force-pushed
the
issue-7-fix-nested-slot-issues-and-more
branch
from
a23d8b7
to
8f42f19
Compare
|
Closing this out in favor of patricknelson/svelte-retag#5 on separate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closed this out in favor of patricknelson/svelte-retag#5 on separate
svelte-retagpackage. Original description is below.🚨 Warning: This is a work in progress, intended as a proof of concept for now only 🚨
Primarily addresses #7 by doing the following:
This may necessitate further refactor later. Right now it's still using my own IDE's code style so -- sorry about that. Please consider adopting this but if you'd prefer, I can still reformat to match repo style if desired. See whitespace ignored version here for cleaner diff: https://github.com/crisward/svelte-tag/pull/18/files?diff=split&w=1