Fix for #12 (take 2): Ensure original named slot tags are retained when not using shadow root. #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en not using shadow root. Take 2 required to account for new unit testing framework (Vitest) from PR #14.
patricknelson
commented
Jun 5, 2023
| @@ -95,7 +95,7 @@ export default function(opts){ | |||
| const namedSlots = this.querySelectorAll('[slot]') | |||
| let slots = {} | |||
| namedSlots.forEach(n=>{ | |||
| slots[n.slot] = this.unwrap(n) | |||
| slots[n.slot] = n | |||
There was a problem hiding this comment.
This is the primary change (which includes the wrapping <div slot="inner"> which is typical in normal Svelte output when using named slots).
This was referenced Jun 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a second attempt at addressing issue #12. This is required to account for new unit testing framework (Vitest) was was merged from PR #14.
Easier to review while hiding whitespace (since my editor trims trailing whitespace, which the current file still has a little bit of): https://github.com/crisward/svelte-tag/pull/15/files?diff=unified&w=1