Add attachment settings toggle and template automation #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced a new toggle setting to enable/disable the use of attachment settings. - Updated the settings tab to reflect this new option. test: add unit tests for PDF to Markdown conversion - Created comprehensive tests for the `convertPDFsToMarkdown` function. - Included scenarios for both enabled and disabled attachment settings. chore: update dependencies and add testing framework - Updated `@types/node` to version 20.11.30. - Added `vitest` as a testing framework and configured it. - Updated package.json scripts to include a test command.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a few behaviors that make this plugin something I will use nearly every day!
NOTE: This is the first time I've done any Obsidian plugin development, and I'm not especially proficient with TypeScript in general (I'm mostly a backend developer), so there's probably plenty of improvement that can be done to this!