Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added border to thumbnail #360

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Queen-codes
Copy link
Contributor

@Queen-codes Queen-codes commented Feb 13, 2025

Fixes

Description

  • adds a border around the thumbnail to improve contrast between images and background, especially for white images.

Screenshots

127 0 0 1_4000_

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@Queen-codes Queen-codes requested a review from a team as a code owner February 13, 2025 11:31
@Queen-codes Queen-codes requested review from TimidRobot and Shafiya-Heena and removed request for a team February 13, 2025 11:31
@possumbilities possumbilities requested review from possumbilities and removed request for Shafiya-Heena February 13, 2025 14:18
@possumbilities
Copy link
Contributor

possumbilities commented Feb 13, 2025

@Queen-codes The idea of adding the border sounded nice in theory, but after seeing it I'm not sure it works. It's not your implementation, as much as adding a border calls attention to the varying heights of the boxes, which makes the layout more noisy. It also makes the text appear more crowded now that the individual items have harsher edges.

To continue with a border in this fashion we'd need all the "cards" to be equal height on each row, and for the cards to get additional inner padding around the text to improve readability. The border also needs to be dialed down in contrast to be something more subtle (a lighter grey perhaps?)

I think those changes might correct the above, but we may find out borders won't work in the end, but I do think its worth continuing to try some other routes first.

@Queen-codes
Copy link
Contributor Author

thank you @possumbilities . I'll give these suggestions a try

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In review
Development

Successfully merging this pull request may close these issues.

[Feature] Add Card Design to Thumbnails for Improved Contrast
2 participants