Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix : added card design to thumbnail #369

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ramirocruz07
Copy link

@ramirocruz07 ramirocruz07 commented Feb 25, 2025

Fixes

Description

Added shadows to the thumbnail to improve contrast and enhance the card design for better visibility.

Technical details

  • Used CSS box-shadow to create a subtle yet effective shadow around the thumbnail.
  • Ensured responsiveness across different screen sizes.

Tests

  • Verified the shadow effect on multiple screen resolutions.
  • Tested the contrast improvement in both light and dark mode (if applicable).

Screenshots

AFTER
Screenshot 2025-02-25 144346

BEFORE
Screenshot 2025-02-25 144422

Checklist

  • My pull request has a descriptive title.
  • My pull request targets the default branch (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I verified that there are no visible errors after my changes.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@ramirocruz07 ramirocruz07 requested a review from a team as a code owner February 25, 2025 09:22
@ramirocruz07 ramirocruz07 requested review from TimidRobot and Shafiya-Heena and removed request for a team February 25, 2025 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In review
Development

Successfully merging this pull request may close these issues.

1 participant