[COZY-445] refac: RoomStatUtil 분리 및 적용 #214

veronees · 2024-12-05T13:18:04Z

⚒️develop의 최신 커밋을 pull 받았나요?

#️⃣ 작업 내용

어떤 기능을 구현했나요?
기존 기능에서 어떤 점이 달라졌나요?
자세한 로직이 필요하다면 함께 적어주세요!
코드에 대한 설명이라면, 코맨트를 통해서 어떤 부분이 어떤 코드인지 설명해주세요!

방 일치율 계산 메서드, 칩 일치수 계산 메서드를 RoomStatUtil 클래스로 분리했습니다
RoomQueryService, RoomRecommendService, FavoriteQueryService에 적용했습니다
성능 개선을 위해 페치조인 사용하도록 일부 수정했습니다

동작 확인

기능을 실행했을 때 정상 동작하는지 여부를 확인하고 스샷을 올려주세요

수정 전 방 추천 조회

수정 후 방 추천 조회 - 칩 일치수 반환 형태가 좀 수정되었습니다

찜한 방 조회

RoomQueryService에서 4개? RoomStatUtil로 변경되었는데 그 중 한개 테스트

일치율 잘 나옵니다

💬 리뷰 요구사항(선택)

리뷰어가 특별히 봐주었으면 하는 부분이 있다면 작성해주세요
고민사항도 적어주세요.

@eple0329 @suuu0719 두 분 코드 조금 수정해서 확인해주세요~

github-actions · 2024-12-05T13:18:40Z

리뷰해드려요~

FavoriteQueryService.java

새로운 Hashtag 클래스 참조 추가
새로운 RoomStatUtil 클래스 참조 추가
멤버 스탯과 멤버 정보를 모두 가져오는 메소드 추가
선호도 정보를 모두 가져오는 메소드 추가
선호도 계산 메소드를 RoomStatUtil로 이동

MateRepository.java

멤버 스탯과 멤버 정보를 모두 가져오는 메소드 추가

RoomRecommendConverter.java

선호도 정보를 모두 가져오는 목록 추가

RoomRecommendationResponseDTO.java

선호도 정보를 모두 가져오는 목록 추가

RoomQueryService.java

선호도 계산 메소드를 RoomStatUtil로 이동

RoomRecommendService.java

선호도 계산 메소드를 RoomStatUtil로 이동
선호도 정보를 모두 가져오는 메소드 추가
선호도 정보를 모두 가져오는 목록 추가

RoomStatUtil.java

새로운 유틸리티 클래스 추가
선호도 정보를 모두 가져오는 메소드 추가
선호도 정보를 모두 가져오는 목록 추가
선호도 계산 메소드 추가
선호도 계산 메소드 추가

veronees · 2024-12-05T13:23:06Z

src/main/java/com/cozymate/cozymate_server/domain/favorite/service/FavoriteQueryService.java

@@ -133,7 +133,7 @@ public List<FavoriteRoomResponseDTO> getFavoriteRoomList(Member member) {
        // <방 id, 해당 방의 mate 리스트>
        Map<Long, List<Mate>> roomIdMatesMap = responseRoomList.stream().collect(
            Collectors.toMap(Room::getId,
-                room -> mateRepository.findFetchMemberByRoom(room, EntryStatus.JOINED)));
+                room -> mateRepository.findFetchMemberAndMemberStatByRoom(room, EntryStatus.JOINED)));


mate의 Member와 Member의 MemberStat에 대한 쿼리가 추가로 날아가서 페치 조인으로 변경했습니다

veronees · 2024-12-05T13:23:28Z

src/main/java/com/cozymate/cozymate_server/domain/favorite/service/FavoriteQueryService.java

+                        ? RoomStatUtil.getPreferenceStatsMatchCounts(member, criteriaPreferenceList,
+                        mates, memberStat)
+                        : RoomStatUtil.getPreferenceStatsMatchCountsWithoutMemberStat(
+                            criteriaPreferenceList);


유틸 클래스 사용으로 수정했습니다

veronees · 2024-12-05T13:24:21Z

src/main/java/com/cozymate/cozymate_server/domain/favorite/service/FavoriteQueryService.java

-                List<String> roomHashTags = roomHashtagRepository.findHashtagsByRoomId(
-                    room.getId());
+                List<RoomHashtag> roomHashtags = room.getRoomHashtags();
+                List<String> roomHashTags = roomHashtags.stream()
+                    .map(RoomHashtag::getHashtag)
+                    .map(Hashtag::getHashtag)
+                    .toList();


방 조회시 RoomHashTag도 같이 가져오는걸 확인해서 쿼리 안날리도록 수정했습니다

veronees · 2024-12-05T13:24:59Z

src/main/java/com/cozymate/cozymate_server/domain/room/service/RoomQueryService.java

@@ -71,7 +72,7 @@ public RoomDetailResponseDTO getRoomById(Long roomId, Long memberId) {
        Map<Long, Integer> equalityMap = memberStatEqualityQueryService.getEquality(memberId,
            joinedMates.stream().map(mate -> mate.getMember().getId()).collect(Collectors.toList()));

-        Integer roomEquality = getCalculateRoomEquality(equalityMap);
+        Integer roomEquality = RoomStatUtil.getCalculateRoomEquality(equalityMap);


RoomStatUtil 적용 1

veronees · 2024-12-05T13:25:07Z

src/main/java/com/cozymate/cozymate_server/domain/room/service/RoomQueryService.java

@@ -209,7 +202,7 @@ public List<RoomDetailResponseDTO> getRoomList(Long memberId, EntryStatus entryS
                List<Mate> joinedMates = mateRepository.findAllByRoomIdAndEntryStatus(room.getId(), EntryStatus.JOINED);
                Map<Long, Integer> equalityMap = memberStatEqualityQueryService.getEquality(memberId,
                    joinedMates.stream().map(mate -> mate.getMember().getId()).collect(Collectors.toList()));
-                Integer roomEquality = getCalculateRoomEquality(equalityMap);
+                Integer roomEquality = RoomStatUtil.getCalculateRoomEquality(equalityMap);


RoomStatUtil 적용 2

veronees · 2024-12-05T13:25:12Z

src/main/java/com/cozymate/cozymate_server/domain/room/service/RoomQueryService.java

@@ -307,7 +300,7 @@ public List<RoomSearchResponseDTO> searchRooms(String keyword, Long memberId) {
                    );
                    return RoomConverter.toRoomSearchResponseDTO(
                        room,
-                        getCalculateRoomEquality(equalityMap)
+                        RoomStatUtil.getCalculateRoomEquality(equalityMap)


RoomStatUtil 적용 3

veronees · 2024-12-05T13:25:17Z

src/main/java/com/cozymate/cozymate_server/domain/room/service/RoomQueryService.java

@@ -330,7 +323,7 @@ public List<RoomSearchResponseDTO> searchRooms(String keyword, Long memberId) {
                );
                return RoomConverter.toRoomSearchResponseDTO(
                    room,
-                    getCalculateRoomEquality(equalityMap)
+                    RoomStatUtil.getCalculateRoomEquality(equalityMap)


RoomStatUtil 적용 4

veronees · 2024-12-05T13:26:54Z

src/main/java/com/cozymate/cozymate_server/domain/room/service/RoomRecommendService.java

+        Map<Long, List<Mate>> roomMateMap = mateRepository.findAllFetchMemberAndMemberStatByEntryStatus(
+                EntryStatus.JOINED)


여기도 페치조인 적용했어요

veronees · 2024-12-05T13:27:23Z

src/main/java/com/cozymate/cozymate_server/domain/room/service/RoomRecommendService.java

+        List<PreferenceMatchCountDTO> preferenceStatsMatchCounts = RoomStatUtil.getPreferenceStatsMatchCounts(
+            member, preferenceList, roomMateMap.get(room.getId()), member.getMemberStat());


RoomStatUtil 사용으로 변경했습니다

veronees · 2024-12-05T13:27:54Z

src/main/java/com/cozymate/cozymate_server/domain/room/service/RoomRecommendService.java

+        List<PreferenceMatchCountDTO> preferenceMatchCountDTOList = RoomStatUtil.getPreferenceStatsMatchCountsWithoutMemberStat(
+            memberPreferenceList);


RoomStatUtil 사용으로 변경했습니다2

github-actions · 2024-12-05T13:30:40Z

리뷰해드려요~

FavoriteQueryService.java - Review 1

새로운 RoomStatUtil 클래스를 사용하여 함수 내부에서 계산되는 것을 제거했습니다.
변경 전:

private List<PreferenceMatchCountDTO> getPreferenceStatsMatchCounts(Member member,
        List<String> criteriaPreferenceList, List<Mate> mates, MemberStat memberStat) {
    // 선호 스탯 일치 횟수 계산
    List<PreferenceMatchCountDTO> preferenceMatchCountDTOList = criteriaPreferenceList.stream()
        .map(preference -> {
            long equalCount = mates.stream()
                .map(mate -> mate.getMember().getMemberStat())
                .filter(mateStat -> mateStat != null && !mateStat.getMember().getId().equals(
                    member.getId())
                    && Objects.equals(MemberStatUtil.getMemberStatField(mateStat, preference),
                    MemberStatUtil.getMemberStatField(memberStat, preference)))
                .count();

            return PreferenceMatchCountDTO.builder()
                .preferenceName(preference)
                .count((int) equalCount)
                .build();
        }).toList();

    return preferenceMatchCountDTOList;
}

변경 후:

private List<PreferenceMatchCountDTO> getPreferenceStatsMatchCounts(Member member,
        List<String> criteriaPreferenceList, List<Mate> mates, MemberStat memberStat) {
    return RoomStatUtil.getPreferenceStatsMatchCounts(member, criteriaPreferenceList, mates, memberStat);
}

MateRepository.java - Review 2

새로운 메서드 findFetchMemberAndMemberStatByRoom 추가
새로운 메서드 findAllFetchMemberAndMemberStatByEntryStatus 추가

RoomRecommendConverter.java - Review 3

새로운 필드 preferenceMatchCountList 추가

RoomRecommendationResponseDTO.java - Review 4

새로운 필드 preferenceMatchCountList 추가

RoomQueryService.java - Review 5

새로운 RoomStatUtil 클래스를 사용하여 함수 내부에서 계산되는 것을 제거했습니다.
변경 전:

private Integer getCalculateRoomEquality(Map<Long, Integer> equalityMap){
    List<Integer> roomEquality = equalityMap.values().stream()
        .toList();
    int sum = roomEquality.stream().mapToInt(Integer::intValue).sum();
    return roomEquality.isEmpty() ? null : sum / roomEquality.size();
}

변경 후:

private Integer getCalculateRoomEquality(Map<Long, Integer> equalityMap){
    return RoomStatUtil.getCalculateRoomEquality(equalityMap);
}

RoomRecommendService.java - Review 6

새로운 RoomStatUtil 클래스를 사용하여 함수 내부에서 계산되는 것을 제거했습니다.
변경 전:

private Map<Long, Integer> calculateRoomEqualityMap(List<Room> roomList, Member member,
        Map<Long, List<Mate>> roomMateMap) {
    // 코드 생략
}

변경 후:

private HashMap<Long, Integer> calculateRoomEqualityMap(List<Room> roomList, Member member,
        Map<Long, List<Mate>> roomMateMap) {
    // 코드 생략
}

RoomStatUtil.java - Review 7

새로운 클래스 추가
새로운 메서드 getPreferenceStatsMatchCounts 추가
새로운 메서드 getPreferenceStatsMatchCountsWithoutMemberStat 추가
새로운 메서드 getCalculateRoomEquality 추가

추가 개선 사항:

RoomStatUtil 클래스를 사용하여 코드를 간소화하고 재사용 가능한 코드를 만들었습니다.
메서드 내부에서 계산되는 것을 제거하여 코드의 가독성을 향상시켰습니다.

github-actions · 2024-12-05T20:04:13Z

리뷰해드려요~

src/main/java/com/cozymate/cozymate_server/domain/favorite/service/FavoriteQueryService.java

Removed the import for com.cozymate.cozymate\_server.domain.roomhashtag.repository.RoomHashtagRepository and added an import for com.cozymate.cozymate\_server.domain.roomhashtag.RoomHashtag.
Changed the method findHashtagsByRoomId to getRoomHashtags and modified the return type to List<RoomHashtag>.
Changed the method findFetchMemberByRoom to findFetchMemberAndMemberStatByRoom and added an import for com.cozymate.cozymate\_server.domain.memberstat.MemberStat.
Modified the method getFavoriteRoomList to use the new method findFetchMemberAndMemberStatByRoom.

src/main/java/com/cozymate/cozymate_server/domain/mate/repository/MateRepository.java

Added two new methods findFetchMemberAndMemberStatByRoom and findAllFetchMemberAndMemberStatByEntryStatus.

src/main/java/com/cozymate/cozymate_server/domain/room/converter/RoomRecommendConverter.java

Added an import for com.cozymate.cozymate\_server.domain.favorite.dto.response.PreferenceMatchCountDTO.
Changed the parameter type of equalMemberStatNum to List<PreferenceMatchCountDTO> in the methods toRoomRecommendationResponse and toRoomRecommendationResponseWhenNoMemberStat.

src/main/java/com/cozymate/cozymate_server/domain/room/dto/response/RoomRecommendationResponseDTO.java

Added an import for com.cozymate.cozymate\_server.domain.favorite.dto.response.PreferenceMatchCountDTO.
Changed the type of equalMemberStatNum to List<PreferenceMatchCountDTO>.

src/main/java/com/cozymate/cozymate_server/domain/room/service/RoomQueryService.java

Added an import for com.cozymate.cozymate\_server.global.utils.RoomStatUtil.
Changed the method getCalculateRoomEquality to use RoomStatUtil.getCalculateRoomEquality.

src/main/java/com/cozymate/cozymate_server/domain/room/service/RoomRecommendService.java

Added an import for com.cozymate.cozymate\_server.global.utils.RoomStatUtil.
Changed the method calculateRoomEqualityMap to use RoomStatUtil.getCalculateRoomEquality.
Changed the method createRoomRecommendationResponse to use RoomStatUtil.getPreferenceStatsMatchCounts.
Changed the method getRoomRecommendationResponseListWhenNoMemberStat to use RoomStatUtil.getPreferenceStatsMatchCountsWithoutMemberStat.

src/main/java/com/cozymate/cozymate_server/global/utils/RoomStatUtil.java

Created a new class RoomStatUtil with the following methods:
getPreferenceStatsMatchCounts
getPreferenceStatsMatchCountsWithoutMemberStat
getCalculateRoomEquality

These changes aim to improve the performance of the application by reducing the number of database queries and improving the readability of the code. The new methods getPreferenceStatsMatchCounts and getPreferenceStatsMatchCountsWithoutMemberStat in the RoomStatUtil class calculate the preference match counts and equality in a more efficient way. The new method findFetchMemberAndMemberStatByRoom in the MateRepository class fetches the member and member stat information in a single query, reducing the number of database queries. The changes in the RoomRecommendConverter and RoomRecommendationResponseDTO classes update the response structure to include the preference match counts instead of the equality map. The changes in the RoomQueryService, RoomRecommendService, and RoomStatUtil classes update the methods to use the new classes and methods.

github-actions · 2024-12-05T20:10:38Z

리뷰해드려요~

FavoriteQueryService.java - Review

Removed @Slf4j annotation.
Removed RoomHashtagRepository dependency.
Added RoomHashtag import.
Added RoomStatUtil import.
Changed mateRepository.findFetchMemberByRoom to mateRepository.findFetchMemberAndMemberStatByRoom.
Changed mateRepository.findAllFetchMemberByEntryStatus to mateRepository.findAllFetchMemberAndMemberStatByEntryStatus.
Changed getPreferenceStatsMatchCounts method to use RoomStatUtil.
Changed getCalculateRoomEquality method to use RoomStatUtil.

MateRepository.java - Review

Added findFetchMemberAndMemberStatByRoom and findAllFetchMemberAndMemberStatByEntryStatus methods.

RoomRecommendConverter.java - Review

Added PreferenceMatchCountDTO import.
Changed equalMemberStatNum to preferenceMatchCountList.

RoomRecommendationResponseDTO.java - Review

Changed equalMemberStatNum to preferenceMatchCountList.

RoomQueryService.java - Review

Added RoomStatUtil import.
Changed getCalculateRoomEquality method to use RoomStatUtil.

RoomRecommendService.java - Review

Removed MemberStatUtil import.
Removed MemberStatEqualityRepository dependency.
Added MemberStatEqualityQueryService dependency.
Changed mateRepository.findAllByEntryStatus to mateRepository.findAllFetchMemberAndMemberStatByEntryStatus.
Changed calculateRoomEqualityMap method to use RoomStatUtil.
Changed createRoomRecommendationResponse method to use RoomStatUtil.
Changed getRoomRecommendationResponseListWhenNoMemberStat method to use RoomStatUtil.

RoomStatUtil.java - Review

Created a new class for room statistic utility methods.
Added PreferenceMatchCountDTO import.
Added MemberStatUtil import.
Added getPreferenceStatsMatchCounts method.
Added getPreferenceStatsMatchCountsWithoutMemberStat method.
Added getCalculateRoomEquality method.

These changes aim to refactor the codebase by moving duplicated logic to a utility class and simplifying the code by removing unnecessary imports and dependencies.

veronees · 2024-12-05T20:12:15Z

src/main/java/com/cozymate/cozymate_server/domain/room/service/RoomRecommendService.java

+            List<Mate> mates = roomMateMap.get(room.getId());
+
+            Map<Long, Integer> equalityMap = memberStatEqualityQueryService.getEquality(
+                member.getId(),
+                mates.stream()
+                    .map(mate -> mate.getMember().getId())
+                    .toList()
+            );
+
+            Integer roomEquality = RoomStatUtil.getCalculateRoomEquality(equalityMap);
+
+            roomEqualityMap.put(room.getId(), roomEquality);


방 일치율 계산하는 부분입니다

jpark0506

LGTM~ join fetch 적용도 좋은 것 같슴당

eple0329

LGTM입니다.
열심히 작성한 방 추천 코드는 다시 만들어졌군요... ㅠㅜ

eple0329 · 2024-12-05T13:20:37Z

src/main/java/com/cozymate/cozymate_server/global/utils/RoomStatUtil.java

global Util말고 room util로 넣어주세요

eple0329 · 2024-12-06T05:15:06Z

src/main/java/com/cozymate/cozymate_server/global/utils/RoomStatUtil.java

이 파일은 Global보다 room에 직접적인 연관이 있는 유틸이니 Room 패키지에 util로 들어가는게 맞다고 봅니당
global은 어떤 도메인과 연관을 가지지 않는 클래스를 놓는거라고 생각해서요

넵 수정했습니다

github-actions · 2024-12-06T06:11:09Z

리뷰해드려요~

FavoriteQueryService.java - Review 1

The RoomHashtagRepository dependency has been removed.
The RoomHashtag class is imported.
The RoomHashtag instance is obtained from the Room instance.
The RoomHashtag instance is utilized to obtain the list of hashtags.

MateRepository.java - Review 1

Two new methods have been added:

findFetchMemberAndMemberStatByRoom: This method returns a list of Mate instances with their corresponding Member and MemberStat instances fetched.
findAllFetchMemberAndMemberStatByEntryStatus: This method returns a list of Mate instances with their corresponding Member and MemberStat instances fetched, filtered by the given EntryStatus.

RoomRecommendConverter.java - Review 1

The PreferenceMatchCountDTO class is imported.
The preferenceMatchCountList parameter has been added to the toRoomRecommendationResponse and toRoomRecommendationResponseWhenNoMemberStat methods.

RoomRecommendationResponseDTO.java - Review 1

The List<PreferenceMatchCountDTO> field has been added.

RoomQueryService.java - Review 1

The RoomStatUtil class is imported.
The getCalculateRoomEquality method has been updated to utilize the RoomStatUtil class.

RoomRecommendService.java - Review 1

The RoomStatUtil class is imported.
The calculateRoomEqualityMap method has been updated to utilize the RoomStatUtil class.
The createRoomRecommendationResponse method has been updated to utilize the RoomStatUtil class.

RoomStatUtil.java - Review 1

This class has been created to contain methods related to room statistics.
The getPreferenceStatsMatchCounts method has been added to calculate the preference match counts.
The getPreferenceStatsMatchCountsWithoutMemberStat method has been added to calculate the preference match counts without a member stat.
The getCalculateRoomEquality method has been added to calculate the room equality.

In conclusion, the changes are focused on refactoring and optimizing the code related to room statistics and preferences. The RoomStatUtil class has been introduced to centralize the logic related to room statistics. The MateRepository class has been updated to include methods that fetch Member and MemberStat instances along with Mate instances. The RoomRecommendConverter and RoomRecommendationResponseDTO classes have been updated to include the PreferenceMatchCountDTO list. The RoomQueryService and RoomRecommendService classes have been updated to utilize the RoomStatUtil class.

veronees added 4 commits December 5, 2024 22:04

[COZY-445] refac: 방 일치율, 칩 일치수를 계산하는 메서드를 유틸 클래스로 분리한다

f138617

[COZY-445] refac: RoomStatUtil을 적용한다

b67a162

[COZY-445] fix: 찜한 방 조회에 RoomStatUtil을 적용 및 성능 개선을 위해 로직을 수정한다

8427e1a

[COZY-445] fix: 방 추천 목록 조회에 RoomStatUtil을 적용 및 일부 로직을 수정한다

b7b2db5

veronees added the enhancement New feature or request label Dec 5, 2024

veronees self-assigned this Dec 5, 2024

veronees requested review from eple0329, genius00hwan, jpark0506 and suuu0719 as code owners December 5, 2024 13:18

veronees changed the title ~~[COZY-445] feat: RoomStatUtil 구현 및 적용~~ [COZY-445] refac: RoomStatUtil 구현 및 적용 Dec 5, 2024

veronees changed the title ~~[COZY-445] refac: RoomStatUtil 구현 및 적용~~ [COZY-445] refac: RoomStatUtil 분리 및 적용 Dec 5, 2024

veronees commented Dec 5, 2024

View reviewed changes

[COZY-445] fix: 미사용 어노테이션을 삭제한다

53ffc6c

[COZY-445] refac: 방 일치율 계산 로직을 메서드 추출한다

87664e8

[COZY-445] refac: 파라미터 순서를 변경한다

21c8eef

veronees commented Dec 5, 2024

View reviewed changes

jpark0506 approved these changes Dec 6, 2024

View reviewed changes

eple0329 approved these changes Dec 6, 2024

View reviewed changes

veronees added 2 commits December 6, 2024 15:09

[COZY-445] refac: 미사용 어노테이션을 삭제한다

9c53a4f

[COZY-445] refac: RoomStatUtil의 패키지 위치를 global -> room으로 변경한다

3de4880

veronees merged commit 8225f14 into develop Dec 6, 2024
1 check passed

eple0329 deleted the feature/COZY-445 branch December 6, 2024 06:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[COZY-445] refac: RoomStatUtil 분리 및 적용 #214

[COZY-445] refac: RoomStatUtil 분리 및 적용 #214

veronees commented Dec 5, 2024 •

edited

Loading

github-actions bot commented Dec 5, 2024

veronees Dec 5, 2024

veronees Dec 5, 2024

veronees Dec 5, 2024

veronees Dec 5, 2024

veronees Dec 5, 2024

veronees Dec 5, 2024

veronees Dec 5, 2024

veronees Dec 5, 2024

veronees Dec 5, 2024

veronees Dec 5, 2024

github-actions bot commented Dec 5, 2024

github-actions bot commented Dec 5, 2024

github-actions bot commented Dec 5, 2024

veronees Dec 5, 2024

jpark0506 left a comment

eple0329 left a comment

eple0329 Dec 5, 2024

eple0329 Dec 6, 2024

veronees Dec 6, 2024

github-actions bot commented Dec 6, 2024

		Map<Long, List<Mate>> roomMateMap = mateRepository.findAllFetchMemberAndMemberStatByEntryStatus(
		EntryStatus.JOINED)

		List<PreferenceMatchCountDTO> preferenceStatsMatchCounts = RoomStatUtil.getPreferenceStatsMatchCounts(
		member, preferenceList, roomMateMap.get(room.getId()), member.getMemberStat());

		List<PreferenceMatchCountDTO> preferenceMatchCountDTOList = RoomStatUtil.getPreferenceStatsMatchCountsWithoutMemberStat(
		memberPreferenceList);

[COZY-445] refac: RoomStatUtil 분리 및 적용 #214

[COZY-445] refac: RoomStatUtil 분리 및 적용 #214

Conversation

veronees commented Dec 5, 2024 • edited Loading

⚒️develop의 최신 커밋을 pull 받았나요?

#️⃣ 작업 내용

동작 확인

💬 리뷰 요구사항(선택)

github-actions bot commented Dec 5, 2024

리뷰해드려요~

FavoriteQueryService.java

MateRepository.java

RoomRecommendConverter.java

RoomRecommendationResponseDTO.java

RoomQueryService.java

RoomRecommendService.java

RoomStatUtil.java

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Dec 5, 2024

리뷰해드려요~

FavoriteQueryService.java - Review 1

MateRepository.java - Review 2

RoomRecommendConverter.java - Review 3

RoomRecommendationResponseDTO.java - Review 4

RoomQueryService.java - Review 5

RoomRecommendService.java - Review 6

RoomStatUtil.java - Review 7

github-actions bot commented Dec 5, 2024

리뷰해드려요~

github-actions bot commented Dec 5, 2024

리뷰해드려요~

FavoriteQueryService.java - Review

MateRepository.java - Review

RoomRecommendConverter.java - Review

RoomRecommendationResponseDTO.java - Review

RoomQueryService.java - Review

RoomRecommendService.java - Review

RoomStatUtil.java - Review

Choose a reason for hiding this comment

jpark0506 left a comment

Choose a reason for hiding this comment

eple0329 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Dec 6, 2024

리뷰해드려요~

FavoriteQueryService.java - Review 1

MateRepository.java - Review 1

RoomRecommendConverter.java - Review 1

RoomRecommendationResponseDTO.java - Review 1

RoomQueryService.java - Review 1

RoomRecommendService.java - Review 1

RoomStatUtil.java - Review 1

veronees commented Dec 5, 2024 •

edited

Loading