[COZY-441] fix: 멤버 스탯 없는 사용자에 대한 찜 수정 #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veronees
requested review from
eple0329,
genius00hwan,
jpark0506 and
suuu0719
as code owners
리뷰해드려요~PreferenceMatchCountDTO.java - 리뷰 1
FavoriteCommandService.java - 리뷰 1
FavoriteQueryService.java - 리뷰 1
MemberStatConverter.java - 리뷰 1
추가 개선 사항:
|
veronees
commented
Dec 4, 2024
Comment on lines
-65
to
-67
| if (Objects.isNull(member.getMemberStat())) { | ||
| throw new GeneralException(ErrorStatus._FAVORITE_CANNOT_MEMBER_WITHOUT_MEMBERSTAT); | ||
| } |
There was a problem hiding this comment.
멤버 스탯 없으면 사용자 찜 못하던 예외 처리를 삭제했습니다
Comment on lines
+76
to
+84
| .map(favoriteMember -> { | ||
| if (Objects.isNull(memberStat)) { | ||
| return FavoriteConverter.toFavoriteMemberResponseDTO( | ||
| memberIdFavoriteIdMap.get(favoriteMember.getId()), | ||
| MemberStatConverter.toPreferenceResponseDTO( | ||
| favoriteMember.getMemberStat(), | ||
| MemberStatConverter.toMemberStatPreferenceDetailWithoutColorDTOList( | ||
| favoriteMember.getMemberStat(), criteriaPreferences), null)); | ||
| } |
There was a problem hiding this comment.
본인이 멤버 스탯이 없는 경우에 대한 처리를 추가했습니다
Comment on lines
-200
to
+210
| .count(0) | ||
| .count(null) |
Comment on lines
+237
to
+246
| public static List<MemberStatPreferenceDetailColorDTO> toMemberStatPreferenceDetailWithoutColorDTOList( | ||
| MemberStat memberStat, List<String> preferences) { | ||
| Map<String, Object> memberStatMap = MemberStatUtil.getMemberStatFields(memberStat, | ||
| preferences); | ||
|
|
||
| return memberStatMap.entrySet().stream() | ||
| .map(entry -> MemberStatConverter.toMemberStatPreferenceDetailWithoutColorDTO( | ||
| entry.getKey(), entry.getValue())) | ||
| .toList(); | ||
| } |
There was a problem hiding this comment.
멤버 스탯 없는 사용자에 대해 color 처리를 위해 추가했습니다
Comment on lines
+257
to
+263
| public static MemberStatPreferenceDetailColorDTO toMemberStatPreferenceDetailWithoutColorDTO( | ||
| String stat, Object value) { | ||
| return MemberStatPreferenceDetailColorDTO.builder() | ||
| .stat(stat) | ||
| .value(value) | ||
| .build(); | ||
| } |
There was a problem hiding this comment.
멤버 스탯 없는 사용자에 대해 color 처리를 위해 추가했습니다22
| int count | ||
| Integer count |
genius00hwan
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⚒️develop의 최신 커밋을 pull 받았나요?
네
#️⃣ 작업 내용
동작 확인
멤버 스탯 없는 테스트 계정으로 사용자 찜하기
찜한 사용자 목록 조회 결과
찜한 방 목록 조회 결과
💬 리뷰 요구사항(선택)