[COZY-432] feat: 사용자가 방에 들어가면 다른 요청들 날리기 #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suuu0719
requested review from
eple0329,
genius00hwan,
jpark0506 and
veronees
as code owners
리뷰해드려요~MateRepository.java
RoomCommandService.java
RoomQueryService.java
|
suuu0719
commented
Dec 3, 2024
There was a problem hiding this comment.
안쓰는것들 지운거라 무시하셔도 됩니다
Comment on lines
+138
to
+139
| if (room.getNumOfArrival() >= room.getMaxMateNum()) { | ||
| throw new GeneralException(ErrorStatus._ROOM_FULL); // 방이 가득 찼을 경우 예외 처리 |
There was a problem hiding this comment.
방 정원 검사를 중구난방으로 하고 있어서 통일했습니다 (무시해도 됨)
| room.arrive(); | ||
| room.isRoomFull(); | ||
| } | ||
|
|
There was a problem hiding this comment.
방 참여시 JOINED STATE로 업데이트
| room.arrive(); | ||
| room.isRoomFull(); | ||
| roomRepository.save(room); | ||
| processJoinRequest(existingMate.get(), room); |
There was a problem hiding this comment.
재입장하는 경우(status가 EXITED)에 대해 processJoinRequest를 호출합니다
| room.isRoomFull(); | ||
| roomRepository.save(room); | ||
| processJoinRequest(existingMate.get(), room); | ||
| clearOtherRoomRequests(memberId); |
There was a problem hiding this comment.
JOINED됐으면 기존 요청들을 날립니다
Comment on lines
+368
to
+369
| processJoinRequest(invitee, room); | ||
| clearOtherRoomRequests(inviteeId); |
Comment on lines
+630
to
+635
| private void clearOtherRoomRequests(Long memberId) { | ||
| mateRepository.deleteAllByMemberIdAndEntryStatusIn( | ||
| memberId, List.of(EntryStatus.PENDING, EntryStatus.INVITED) | ||
| ); | ||
| } | ||
|
|
There was a problem hiding this comment.
PENDING, INVITED 상태인 mate를 모두 삭제합니다
There was a problem hiding this comment.
이부분은 중복되는 코드 묶은거라 무시하셔도 됩니다
eple0329
force-pushed
the
feature/COZY-432
branch
from
3d5eb0a to
1a6dbe7
Compare
리뷰해드려요~MateRepository.java
RoomCommandService.java
RoomQueryService.java
추가적으로 제안하고 싶은 점은 없습니다. |
genius00hwan
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⚒️develop의 최신 커밋을 pull 받았나요?
예
#️⃣ 작업 내용
어떤 방에 들어가는 순간 기존 초대 및 참여 요청을 자동으로 날립니다
동작 확인
memberId 99 → 여러방(57,72,37)에 INVITED, PENDING 상태
방장에게 보이는 참여요청 리스트
99번 참여 요청 수락함
37번 JOINED 룸 제외하고 모든 요청 지워짐
98번 요청을 거절했을때는 안날라감
💬 리뷰 요구사항(선택)