[COZY-411] feat : 사용자 관련 validation 고도화 #198

genius00hwan · 2024-12-01T14:06:04Z

⚒️develop의 최신 커밋을 pull 받았나요?

#️⃣ 작업 내용

어떤 기능을 구현했나요?
기존 기능에서 어떤 점이 달라졌나요?
자세한 로직이 필요하다면 함께 적어주세요!
코드에 대한 설명이라면, 코맨트를 통해서 어떤 부분이 어떤 코드인지 설명해주세요!

동작 확인

clientId, socialType validation

nickname validation

gender validation

💬 리뷰 요구사항(선택)

리뷰어가 특별히 봐주었으면 하는 부분이 있다면 작성해주세요
고민사항도 적어주세요.

github-actions · 2024-12-01T14:06:49Z

리뷰해드려요~

ClientIdMaker.java - Review

변경사항: ':' 기호로 클라이언트 아이디를 만드는 방식이 변경되었습니다.

Member.java - Review

추가: 'persona' 필드에 대한 범위 제한이 추가되었습니다.

MemberController.java - Review

제거: 'BindingResult' 파라미터가 제거되었습니다.
추가: 'Nickname' 필드에 대한 길이 제한이 추가되었습니다.
추가: 'persona' 필드에 대한 범위 제한이 추가되었습니다.

SignInRequestDTO.java - Review

추가: 'SocialType' 필드에 대한 유효성 검사가 추가되었습니다.

SignUpRequestDTO.java - Review

제거: 'max' 및 'min' 제한 정보가 제거되었습니다.
추가: 'nickname' 필드에 대한 길이 제한이 추가되었습니다.
추가: 'gender' 필드에 대한 유효성 검사가 추가되었습니다.
추가: 'birthday' 필드에 대한 날짜 형식 제한이 추가되었습니다.
추가: 'persona' 필드에 대한 범위 제한이 추가되었습니다.

Gender.java - Review

제거: 'ErrorStatus' 및 'GeneralException' 클래스가 제거되었습니다.

SocialType.java - Review

제거: 'ErrorStatus' 및 'GeneralException' 클래스가 제거되었습니다.

MemberCommandService.java - Review

제거: 'isValidNickName' 메서드가 제거되었습니다.

MemberQueryService.java - Review

제거: 'isValidNickName' 메서드가 제거되었습니다.
추가: 'isValidNickName' 메서드에 대한 예외 처리가 추가되었습니다.

MessageSourceConfig.java - Review

추가: 'MessageSource' 구성 파일이 추가되었습니다.

ErrorStatus.java - Review

추가: '_INVALID_NICKNAME_PATTERN' 및 '_INVALID_NICKNAME_LENGTH' 코드가 추가되었습니다.

EnumValidator.java - Review

변경: 'equals' 메서드에서 'equalsIgnoreCase' 메서드로 변경되었습니다.

EnumValue.java - Review

추가: 'getValue' 메서드가 추가되었습니다.

github-actions · 2024-12-01T14:08:38Z

리뷰해드려요~

ClientIdMaker.java - Review

Changed clientId = "12345@KAKAO" to clientId = "12345:KAKAO"

Member.java - Review

Added @Range(min = 1, max = 16) annotation to persona field

MemberController.java - Review

Changed @Max(value = 16) and @Min(value = 1) annotations to @Range(min = 1, max = 16) annotation for persona parameter
Added @NotEmpty and @NotNull annotations to nickname parameter
Added @NotEmpty and @NotNull annotations to majorName parameter

SignInRequestDTO.java - Review

Added @NotEmpty and @NotNull annotations to clientId field
Added @NotEmpty and @NotNull annotations to socialType field

SignUpRequestDTO.java - Review

Added @NotEmpty and @NotNull annotations to nickname field
Added @NotEmpty and @NotNull annotations to gender field
Added @DateTimeFormat(pattern = "yyyy-MM-dd") annotation to birthday field
Added @Range(min = 1, max = 16) annotation to persona field

Gender.java - Review

Removed unused imports

SocialType.java - Review

Removed unused imports

MemberCommandService.java - Review

Changed log.debug to log.info

MemberQueryService.java - Review

Changed isValidNickName method to throw an exception if the nickname already exists
Changed isValidNickName method to throw an exception if the nickname does not match the pattern
Changed isValidNickName method to throw an exception if the nickname length is not between 2 and 8
Removed unused method searchByNickname

MessageSourceConfig.java - Review

Added new file

ErrorStatus.java - Review

Added new error codes for invalid nickname pattern and length

EnumValidator.java - Review

Changed equals method to equalsIgnoreCase method

EnumValue.java - Review

Added new file for getting enum value by name

genius00hwan · 2024-12-01T14:07:18Z

src/main/java/com/cozymate/cozymate_server/global/utils/EnumValidator.java

베로가 만든 @EnumValid 를 가져다 쓰면서 수정하고 싶은 부분을 수정했습니다.
원래 Enum Name과 일치한지를 봤는데 대소문자 건너 뛰고 검증합니다.

genius00hwan · 2024-12-01T14:09:15Z

src/main/java/com/cozymate/cozymate_server/global/utils/EnumValue.java

@@ -0,0 +1,12 @@
+package com.cozymate.cozymate_server.global.utils;


enum 쓰실 때 valueOf()대신 이거 구현하셔서 getValue()쓰시는걸 추천합니다. 대소문자 상관없이 값을 추출합니다

getValue를 어떤 이유 때문에 추천하시나요?

genius00hwan · 2024-12-01T14:10:01Z

src/main/java/com/cozymate/cozymate_server/domain/member/enums/SocialType.java

-                .filter(socialType -> socialType.name().equalsIgnoreCase(socialTypeString))
-                .findFirst()
-                .orElseThrow( () -> new GeneralException(ErrorStatus._INVALID_SOCIAL_TYPE));
+    public static SocialType getValue(String socialTypeString){


Enum 쓰신다면 밑에 EnumValue 인터페이스 어케 생긴지 보시고 이것처럼 구현 하시면 좋을 것 같습니다!!

github-actions · 2024-12-01T14:11:58Z

리뷰해드려요~

{ClientIdMaker.java}

Changed clientId = "12345@KAKAO" to clientId = "12345:KAKAO"
This change is likely to ensure that the client id format follows a specific pattern.

{Member.java}

Added @Range(min = 1, max = 16) annotation to the persona field
This change is likely to ensure that the persona value is within a specific range.

{MemberController.java}

Added @Range(min = 1, max = 16) annotation to the persona parameter in the updatePersona method
This change is likely to ensure that the persona value passed to the method is within a specific range.

{SignInRequestDTO.java}

Added @NotNull and @NotEmpty annotations to the clientId and socialType fields
This change is likely to ensure that these fields cannot be null or empty.

{SignUpRequestDTO.java}

Added @NotNull and @NotEmpty annotations to the nickname, gender, and universityId fields
Added @Length(min = 2, max = 8) annotation to the nickname field
Added @Range(min = 1, max = 16) annotation to the persona field
This change is likely to ensure that these fields cannot be null or empty and that the nickname length and persona value are within specific ranges.

{Gender.java}

Removed unused imports and methods
This change is likely to simplify the code and remove unnecessary dependencies.

{SocialType.java}

Removed unused imports and methods
This change is likely to simplify the code and remove unnecessary dependencies.

{MemberCommandService.java}

Changed log.debug to log.info for the clientId log message
This change is likely to ensure that the log message is more visible in the logs.

{MemberQueryService.java}

Added NICKNAME_PATTERN constant and updated the isValidNickName method
This change is likely to ensure that the nickname follows a specific pattern and is not already in use.

{ErrorStatus.java}

Added _INVALID_NICKNAME_PATTERN and _INVALID_NICKNAME_LENGTH constants
This change is likely to provide more specific error messages for invalid nicknames.

{EnumValidator.java}

Changed value.equals(enumValue.toString()) to value.equalsIgnoreCase(enumValue.toString())
This change is likely to ensure that the enum value comparison is case-insensitive.

{EnumValue.java}

Added EnumValue interface and implementation
This change is likely to provide a reusable method for getting enum values based on a string value.

It's important to note that these changes are based on a code review and may not reflect the full context or reasoning behind each change. It's always best to consult with the developer or team responsible for the code to fully understand the changes and their implications.

veronees

LGTM~ 제 코드도 getValue()로 바꿔야겠네요

veronees · 2024-12-02T11:57:00Z

src/main/java/com/cozymate/cozymate_server/domain/member/dto/request/SignInRequestDTO.java

+    @NotNull(message = "null일 수 없습니다.")
+    @NotEmpty(message = "비어 있을 수 없습니다.")


이부분 @notblank 하나로 대체 가능할 것 같은데,
상황별로 자세한 메시지 응답하려는 의도인가요?

넹 그런 이유로 나눴습니다

eple0329

좋은거같아용

eple0329 · 2024-12-03T13:19:18Z

src/main/java/com/cozymate/cozymate_server/domain/member/service/MemberCommandService.java

@@ -59,7 +64,7 @@ public SignInResponseDTO signIn(SignInRequestDTO signInRequestDTO) {

        String clientId = ClientIdMaker.makeClientId(signInRequestDTO.clientId(), socialType);

-        log.debug("사용자 로그인 : {}",clientId);
+        log.info("사용자 로그인 : {}", clientId);


해당 부분이 실행되는 API를 호출했을 때 REQUEST에 UserID 출력 안되나요?

아 이거 지금 바꿀게여 debug로 바꿔서 pr올린다는걸 빼먹었네여

jpark0506

LGTM~ 고생하셨습니다

jpark0506 · 2024-12-03T13:19:39Z

src/main/java/com/cozymate/cozymate_server/global/utils/EnumValue.java

@@ -0,0 +1,12 @@
+package com.cozymate.cozymate_server.global.utils;


getValue를 어떤 이유 때문에 추천하시나요?

github-actions · 2024-12-03T13:25:20Z

리뷰해드려요~

ClientIdMaker.java

Changed @ to : in the generateClientId method.

Member.java

Added @Range annotation to the persona field.

MemberController.java

Changed @Max and @Min to @Range annotation for the persona field in the updatePersona method.
Added @NotEmpty and @NotNull annotations to the majorName field in the updateMajorName method.

SignInRequestDTO.java

Added @NotEmpty and @NotNull annotations to the clientId and socialType fields.

SignUpRequestDTO.java

Added @NotEmpty and @NotNull annotations to the nickname, gender, and universityId fields.
Added @Range annotation to the persona field.

Gender.java

Removed unnecessary code.

SocialType.java

Removed unnecessary code.

MemberCommandService.java

Changed isValidNickName method to checkNickname and added exception handling.

MemberQueryService.java

Changed isValidNickName method to throw an exception instead of returning a boolean value.
Removed unnecessary code.

ErrorStatus.java

Added two new error status codes for invalid nickname pattern and length.

EnumValidator.java

Changed equals to equalsIgnoreCase in the isValid method.

EnumValue.java

Added a new interface for getting enum values.

These changes improve the code by adding more validations, simplifying the code, and making it more readable.

* [COZY-411] feat : 예외 메시지 기본 틀 생성 * [COZY-411] feat : enum값 관련 interface 생성 * [COZY-411] feat : 사용자 관련 validation 고도화 * [COZY-411] fix : 에러 메시지 안 쓰게돼서 설정에서 삭제 * [COZY-411] rename : 에러 메시지 안 쓰게돼서 설정파일 삭제 * [COZY-411] fix : log 타입 수정

genius00hwan added 5 commits November 29, 2024 00:07

[COZY-411] feat : 예외 메시지 기본 틀 생성

ec7f8c1

Merge branch 'develop' into member-valid

ab02ed5

[COZY-411] feat : enum값 관련 interface 생성

b3b1ea3

[COZY-411] feat : 사용자 관련 validation 고도화

a45e151

Merge branch 'develop' into member-valid

d39fc41

genius00hwan requested review from eple0329, jpark0506, veronees and suuu0719 as code owners December 1, 2024 14:06

genius00hwan self-assigned this Dec 1, 2024

[COZY-411] fix : 에러 메시지 안 쓰게돼서 설정에서 삭제

ea1f23b

[COZY-411] rename : 에러 메시지 안 쓰게돼서 설정파일 삭제

a13b974

genius00hwan commented Dec 1, 2024

View reviewed changes

genius00hwan added bug Something isn't working enhancement New feature or request and removed bug Something isn't working labels Dec 2, 2024

veronees approved these changes Dec 2, 2024

View reviewed changes

eple0329 approved these changes Dec 3, 2024

View reviewed changes

jpark0506 approved these changes Dec 3, 2024

View reviewed changes

[COZY-411] fix : log 타입 수정

e863fc3

genius00hwan merged commit be332a0 into develop Dec 3, 2024
1 check passed

eple0329 deleted the feature/COZY-411 branch December 4, 2024 12:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[COZY-411] feat : 사용자 관련 validation 고도화 #198

[COZY-411] feat : 사용자 관련 validation 고도화 #198

genius00hwan commented Dec 1, 2024

github-actions bot commented Dec 1, 2024

github-actions bot commented Dec 1, 2024

genius00hwan Dec 1, 2024

genius00hwan Dec 1, 2024 •

edited

Loading

jpark0506 Dec 3, 2024

genius00hwan Dec 1, 2024

github-actions bot commented Dec 1, 2024

veronees left a comment

veronees Dec 2, 2024

genius00hwan Dec 3, 2024

eple0329 left a comment

eple0329 Dec 3, 2024

genius00hwan Dec 3, 2024

jpark0506 left a comment

jpark0506 Dec 3, 2024

github-actions bot commented Dec 3, 2024

		@@ -0,0 +1,12 @@
		package com.cozymate.cozymate_server.global.utils;

		@NotNull(message = "null일 수 없습니다.")
		@NotEmpty(message = "비어 있을 수 없습니다.")

[COZY-411] feat : 사용자 관련 validation 고도화 #198

[COZY-411] feat : 사용자 관련 validation 고도화 #198

Conversation

genius00hwan commented Dec 1, 2024

⚒️develop의 최신 커밋을 pull 받았나요?

#️⃣ 작업 내용

동작 확인

💬 리뷰 요구사항(선택)

github-actions bot commented Dec 1, 2024

리뷰해드려요~

ClientIdMaker.java - Review

Member.java - Review

MemberController.java - Review

SignInRequestDTO.java - Review

SignUpRequestDTO.java - Review

Gender.java - Review

SocialType.java - Review

MemberCommandService.java - Review

MemberQueryService.java - Review

MessageSourceConfig.java - Review

ErrorStatus.java - Review

EnumValidator.java - Review

EnumValue.java - Review

github-actions bot commented Dec 1, 2024

리뷰해드려요~

ClientIdMaker.java - Review

Member.java - Review

MemberController.java - Review

SignInRequestDTO.java - Review

SignUpRequestDTO.java - Review

Gender.java - Review

SocialType.java - Review

MemberCommandService.java - Review

MemberQueryService.java - Review

MessageSourceConfig.java - Review

ErrorStatus.java - Review

EnumValidator.java - Review

EnumValue.java - Review

Choose a reason for hiding this comment

genius00hwan Dec 1, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Dec 1, 2024

리뷰해드려요~

veronees left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

eple0329 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jpark0506 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Dec 3, 2024

리뷰해드려요~

genius00hwan Dec 1, 2024 •

edited

Loading