[COZY-400] feat: 쪽지방 목록 정렬 및 새로운 쪽지 유무 반환 추가, 새로운 쪽지 온 쪽지방 갯수 조회 API, 회원탈퇴 쪽지 null 처리 #191

veronees · 2024-11-26T10:21:21Z

⚒️develop의 최신 커밋을 pull 받았나요?

#️⃣ 작업 내용

어떤 기능을 구현했나요?
기존 기능에서 어떤 점이 달라졌나요?
자세한 로직이 필요하다면 함께 적어주세요!
코드에 대한 설명이라면, 코맨트를 통해서 어떤 부분이 어떤 코드인지 설명해주세요!

쪽지방 목록 정렬
새로운 쪽지 유무 반환 추가
새로운 쪽지가 온 쪽지방 갯수 조회 API
회원탈퇴 쪽지 null 처리

동작 확인

기능을 실행했을 때 정상 동작하는지 여부를 확인하고 스샷을 올려주세요

마지막 쪽지방 읽은 시간 기준 이후에 쪽지가 온 경우 true를 반환

새 쪽지가 눈꽃에서만 왔기 때문에 새로운 쪽지방 갯수 조회 = 1

포비 계정으로 베로에게 쪽지 하나를 보낸 경우 - true반환, 최근 쪽지가 오고 간 순서대로 정렬됌

새로운 쪽지방 갯수 조회 = 2

쪽지방 목록 조회 시 탈퇴한 멤버 (알수없음)으로 처리

탈퇴한 멤버와의 쪽지 상세 조회

💬 리뷰 요구사항(선택)

리뷰어가 특별히 봐주었으면 하는 부분이 있다면 작성해주세요
고민사항도 적어주세요.

null 처리 최대한 한다고 했는데 오류 생기면 수정할게요

아직 쪽지방 삭제는 null 처리하고 테스트를 못해봤어요

github-actions · 2024-11-26T10:21:52Z

리뷰해드려요~

ChatRepository.java

Added existsBySenderAndChatRoomAndCreatedAtAfterOrLastSeenAtIsNull method to check if there is a new chat message.
Imported LocalDateTime and Member classes.

ChatQueryService.java

Modified getChatList method to return ChatListResponseDTO instead of List<Chat>.
Added updateLastSeenAt method to update the last seen at time of the recipient.
Modified toChatResponseDTOList method to handle null sender and add self indicator.
Imported Objects class.

ChatRoom.java

Added memberALastSeenAt and memberBLastSeenAt fields and their corresponding update methods.

ChatRoomController.java

Added getCountChatRoomsWithNewChat method to get the count of chat rooms with new chat messages.
Imported CountChatRoomsWithNewChatDTO class.

ChatRoomConverter.java

Added toCountChatRoomsWithNewChatDTO method to convert the count to CountChatRoomsWithNewChatDTO.
Imported CountChatRoomsWithNewChatDTO class.

ChatRoomDetailResponseDTO.java

Added hasNewChat field.

CountChatRoomsWithNewChatDTO.java

Created a new record class to hold the count of chat rooms with new chat messages.

ChatRoomQueryService.java

Modified getChatRoomList method to return ChatRoomDetailResponseDTO instead of List<ChatRoom>.
Added countChatRoomsWithNewChat method to get the count of chat rooms with new chat messages.
Modified getLatestChatByChatRoom method to handle null sender and recipient.
Modified getLastDeleteAtByMember method to handle null sender and recipient.
Added existNewChat method to check if there is a new chat message.
Imported Objects class.

These changes allow the system to handle new chat messages and update the last seen at time of the recipient. The new endpoint getCountChatRoomsWithNewChat allows the user to get the count of chat rooms with new chat messages. The modified endpoint getChatRoomList returns the list of chat rooms with new chat messages and the last seen at time of the recipient. The modified methods getLatestChatByChatRoom, getLastDeleteAtByMember, and existNewChat handle the null sender and recipient cases. The modified toChatResponseDTOList method handles the null sender case and adds a self indicator.

veronees

코멘트 단 부분 외에는 대부분 null 처리입니다

veronees · 2024-11-26T10:34:04Z

src/main/java/com/cozymate/cozymate_server/domain/chatroom/service/ChatRoomQueryService.java


-        return memberBlockUtil.filterBlockedMember(chatRoomDetailResponseDTOList, member,
-            ChatRoomDetailResponseDTO::memberId);
+    public CountChatRoomsWithNewChatDTO countChatRoomsWithNewChat(Member member) {


새로운 쪽지 온 쪽지방 갯수 계산하는 메서드입니다

veronees · 2024-11-26T10:35:45Z

src/main/java/com/cozymate/cozymate_server/domain/chatroom/service/ChatRoomQueryService.java

                if (chat == null) {
                    return false;
                }
                LocalDateTime lastDeleteAt = getLastDeleteAtByMember(chatRoom, member);
                return lastDeleteAt == null || chat.getCreatedAt().isAfter(lastDeleteAt);
            })
+            .sorted((chatRoomA, chatRoomB) -> {


쪽지방 목록 대화 내용 최신순으로 정렬했습니다

veronees · 2024-11-26T10:37:51Z

src/main/java/com/cozymate/cozymate_server/domain/chatroom/service/ChatRoomQueryService.java

+                if (Objects.isNull(chatRoom.getMemberA()) ||
+                    Objects.isNull(chatRoom.getMemberB())) {
+                    return toChatRoomDetailResponseDTO(chatRoom, member, chat, false);
+                }
+
+                Member recipient = chatRoom.getMemberA().getId().equals(member.getId()) ?
+                    chatRoom.getMemberB() : chatRoom.getMemberA();
+
+                LocalDateTime lastSeenAt = chatRoom.getMemberA().getId().equals(member.getId()) ?
+                    chatRoom.getMemberALastSeenAt() : chatRoom.getMemberBLastSeenAt();
+
+                boolean hasNewChat = existNewChat(recipient, chatRoom, lastSeenAt);
+
+                return toChatRoomDetailResponseDTO(chatRoom, member, chat, hasNewChat);


쪽지방 목록 조회 시 새로운 쪽지 유무 추가하는 부분입니다

eple0329

LGTM

eple0329 · 2024-11-27T12:04:04Z

.../com/cozymate/cozymate_server/domain/chatroom/dto/response/CountChatRoomsWithNewChatDTO.java

+
+@Builder
+public record CountChatRoomsWithNewChatDTO(
+    Integer hasNewChatCount


그냥 newChatCount는 어떤가요? has가 붙으면 boolean을 생각하게 될 것 같습니당

newChatCount보다 좀 더 길지만 확실한 이름으로 변경했슴다

eple0329 · 2024-11-27T12:05:34Z

src/main/java/com/cozymate/cozymate_server/domain/chatroom/service/ChatRoomCommandService.java

+        if (Objects.nonNull(memberALastDeleteAt) && Objects.nonNull(memberBLastDeleteAt)
+            && canHardDelete(chatRoom, memberALastDeleteAt, memberBLastDeleteAt)) {


리팩토링할 때 이런 부분은 따로 함수로 빼서 true, false 반환되는 함수를 만든다면 더 읽기 편할 것 같습니당

jpark0506

LGTM~ 이상 없어보이네요 만약 읽으면 그 상태를 바꿔주는 API는 따로 있는건가요?

github-actions · 2024-11-28T14:55:40Z

리뷰해드려요~

{name} ChatRepository.java
Added a method to check if there is a new chat message for the given member and chat room.
Added a new import for Member and LocalDateTime.
{name} ChatQueryService.java
Added a method to update the last seen at timestamp for the given member and chat room.
Added a new import for LocalDateTime.
Modified the getChatList method to use the new method to update the last seen at timestamp.
Modified the toChatContentResponseDTO method to handle the case when the sender is null.
Removed the checkBlockedMember method and its usage in the getChatList method.
{name} ChatRoom.java
Added two new fields and their corresponding getter and setter methods to store the last seen at timestamps for member A and member B.
{name} ChatRoomController.java
Added a new method to get the count of chat rooms with new chat messages for the given member.
Added a new import for CountChatRoomsWithNewChatDTO.
{name} ChatRoomConverter.java
Added a new method to convert a CountChatRoomsWithNewChatDTO object to a CountChatRoomsWithNewChatDTO object.
Added a new import for CountChatRoomsWithNewChatDTO.
{name} ChatRoomDetailResponseDTO.java
Added a new field and its corresponding getter and setter method to store the hasNewChat flag.
{name} CountChatRoomsWithNewChatDTO.java
Added a new record class to represent the count of chat rooms with new chat messages.
{name} ChatRoomQueryService.java
Added a new method to count the chat rooms with new chat messages for the given member.
Modified the getChatRoomList method to use the new method to count the chat rooms with new chat messages.
Modified the getChatRoom method to use the new method to count the chat rooms with new chat messages.
Added a new import for CountChatRoomsWithNewChatDTO.

The changes made in the code are to add new features to the chat room and chat message functionalities. The new features include checking if there is a new chat message for a given member and chat room, updating the last seen at timestamp for a given member and chat room, and counting the chat rooms with new chat messages for a given member. The changes also include adding new classes and methods to support these new features.

veronees · 2024-11-28T14:58:46Z

해당 쪽지방 마지막 조회 시간 추가해서 마지막 조회 시간으로 새 쪽지 있는지 확인만해용
따로 상태를 바꿔주거나 하진 않습니다

veronees added 3 commits November 26, 2024 19:17

[COZY-400] feat: 새로운 쪽지가 온 쪽지방 갯수 조회 api 구현, 쪽지방 목록 조회 시 새로운 쪽지 유무 추가 반환

37c9e92

[COZY-400] feat: 회원 탈퇴 member null 처리

86db7f7

Merge branch 'develop' into feature/COZY-400

9eab42d

veronees added the enhancement New feature or request label Nov 26, 2024

veronees self-assigned this Nov 26, 2024

veronees requested review from eple0329, genius00hwan, jpark0506 and suuu0719 as code owners November 26, 2024 10:21

veronees commented Nov 26, 2024

View reviewed changes

eple0329 approved these changes Nov 27, 2024

View reviewed changes

jpark0506 approved these changes Nov 28, 2024

View reviewed changes

veronees added 2 commits November 28, 2024 23:54

[COZY-400] fix: dto 필드명 수정

8bbb39a

[COZY-400] refac: if 조건문 내용 메서드 추출

fd4a9db

veronees merged commit 5c81f50 into develop Nov 28, 2024
1 check passed

veronees deleted the feature/COZY-400 branch November 28, 2024 15:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[COZY-400] feat: 쪽지방 목록 정렬 및 새로운 쪽지 유무 반환 추가, 새로운 쪽지 온 쪽지방 갯수 조회 API, 회원탈퇴 쪽지 null 처리 #191

[COZY-400] feat: 쪽지방 목록 정렬 및 새로운 쪽지 유무 반환 추가, 새로운 쪽지 온 쪽지방 갯수 조회 API, 회원탈퇴 쪽지 null 처리 #191

veronees commented Nov 26, 2024 •

edited

Loading

github-actions bot commented Nov 26, 2024

veronees left a comment •

edited

Loading

veronees Nov 26, 2024

veronees Nov 26, 2024

veronees Nov 26, 2024

eple0329 left a comment

eple0329 Nov 27, 2024

veronees Nov 28, 2024

eple0329 Nov 27, 2024

jpark0506 left a comment

github-actions bot commented Nov 28, 2024

veronees commented Nov 28, 2024 •

edited

Loading

		if (Objects.nonNull(memberALastDeleteAt) && Objects.nonNull(memberBLastDeleteAt)
		&& canHardDelete(chatRoom, memberALastDeleteAt, memberBLastDeleteAt)) {

[COZY-400] feat: 쪽지방 목록 정렬 및 새로운 쪽지 유무 반환 추가, 새로운 쪽지 온 쪽지방 갯수 조회 API, 회원탈퇴 쪽지 null 처리 #191

[COZY-400] feat: 쪽지방 목록 정렬 및 새로운 쪽지 유무 반환 추가, 새로운 쪽지 온 쪽지방 갯수 조회 API, 회원탈퇴 쪽지 null 처리 #191

Conversation

veronees commented Nov 26, 2024 • edited Loading

⚒️develop의 최신 커밋을 pull 받았나요?

#️⃣ 작업 내용

동작 확인

💬 리뷰 요구사항(선택)

github-actions bot commented Nov 26, 2024

리뷰해드려요~

veronees left a comment • edited Loading

Choose a reason for hiding this comment

veronees Nov 26, 2024

Choose a reason for hiding this comment

veronees Nov 26, 2024

Choose a reason for hiding this comment

veronees Nov 26, 2024

Choose a reason for hiding this comment

eple0329 left a comment

Choose a reason for hiding this comment

eple0329 Nov 27, 2024

Choose a reason for hiding this comment

veronees Nov 28, 2024

Choose a reason for hiding this comment

eple0329 Nov 27, 2024

Choose a reason for hiding this comment

jpark0506 left a comment

Choose a reason for hiding this comment

github-actions bot commented Nov 28, 2024

리뷰해드려요~

veronees commented Nov 28, 2024 • edited Loading

veronees commented Nov 26, 2024 •

edited

Loading

veronees left a comment •

edited

Loading

veronees commented Nov 28, 2024 •

edited

Loading