Skip to content

Address feedback: path aliases and restore attributes-slot Vitest spec#7181

Merged
louis-bompart merged 2 commits intospring-is-coming-vol1from
copilot/sub-pr-7168
Feb 27, 2026
Merged

Address feedback: path aliases and restore attributes-slot Vitest spec#7181
louis-bompart merged 2 commits intospring-is-coming-vol1from
copilot/sub-pr-7168

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Feb 26, 2026

Addresses review feedback from #7168: fixes relative imports that cross directory boundaries (should use @/ path aliases) and restores test coverage for attributes-slot.ts which was deleted but the module is still in use.

Changes

  • attributes-slot.spec.ts — Re-created as a Vitest unit test (9 tests) covering getAttributesFromLinkSlotContent: empty/non-anchor slots, attribute filtering (slot, href), multi-element warnings, and first-element selection
  • Path alias fixes in three files:
    • bindings-context.ts: '../interface/bindings''@/src/components/common/interface/bindings'
    • bindings.ts: two relative cross-directory imports → @/src/components/common/...
    • accessibility-utils.ts: two relative cross-directory imports → @/src/components/common/...

✅ Checklist

  • 🧪 The component is unit tested
  • 🧪 The component includes E2E tests
  • 🗑️ Old Cypress tests exclusive to the component are removed
  • 📖 The component is documented in storybook with an .mdx file
  • ♿ The component complies with the Web Content Accessibility Guidelines.
  • 🌐 All strings intended for humans or assistive technology must be localized with i18n.
  • 📦 The Lit component is exported in the appropriate index.ts and lazy-index.ts files.
  • 🎨 CSS parts are documented still accessible.
  • 🦥 Slotted Content, public methods and properties are documented
  • 🔄 The component outputs the same Angular output as before with Stencil
  • 🏷️ The component declares the component type in the HTMLElementTagNameMap

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: louis-bompart <12366410+louis-bompart@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix feedback on removing unused stencil files Address feedback: path aliases and restore attributes-slot Vitest spec Feb 26, 2026
@louis-bompart louis-bompart marked this pull request as ready for review February 26, 2026 22:40
Copilot AI temporarily deployed to Prerelease (CDN) February 26, 2026 22:45 Inactive
@louis-bompart louis-bompart merged commit 45fe582 into spring-is-coming-vol1 Feb 27, 2026
62 checks passed
@louis-bompart louis-bompart deleted the copilot/sub-pr-7168 branch February 27, 2026 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants