Address feedback: path aliases and restore attributes-slot Vitest spec#7181
Merged
louis-bompart merged 2 commits intospring-is-coming-vol1from Feb 27, 2026
Merged
Address feedback: path aliases and restore attributes-slot Vitest spec#7181louis-bompart merged 2 commits intospring-is-coming-vol1from
louis-bompart merged 2 commits intospring-is-coming-vol1from
Conversation
Co-authored-by: louis-bompart <12366410+louis-bompart@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix feedback on removing unused stencil files
Address feedback: path aliases and restore attributes-slot Vitest spec
Feb 26, 2026
louis-bompart
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses review feedback from #7168: fixes relative imports that cross directory boundaries (should use
@/path aliases) and restores test coverage forattributes-slot.tswhich was deleted but the module is still in use.Changes
attributes-slot.spec.ts— Re-created as a Vitest unit test (9 tests) coveringgetAttributesFromLinkSlotContent: empty/non-anchor slots, attribute filtering (slot,href), multi-element warnings, and first-element selectionbindings-context.ts:'../interface/bindings'→'@/src/components/common/interface/bindings'bindings.ts: two relative cross-directory imports →@/src/components/common/...accessibility-utils.ts: two relative cross-directory imports →@/src/components/common/...✅ Checklist
.mdxfileindex.tsandlazy-index.tsfiles.💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.