Open
Conversation
louis-bompart
requested review from
a team,
Copilot,
fbeaudoincoveo,
lavoiesl and
y-lakhdar
louis-bompart
temporarily deployed
to
pr-workflows
GitHub Actions
Inactive
louis-bompart
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
louis-bompart
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
louis-bompart
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
louis-bompart
temporarily deployed
to
Prerelease (CDN)
GitHub Actions
Inactive
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes a large set of legacy/unused Stencil helper files from packages/atomic and updates a few imports/typings to align with the remaining Lit-first implementation.
Changes:
- Deleted many deprecated Stencil
FunctionalComponenthelpers and legacy Stencil-only utilities. - Updated
AnyBindingstype imports to targetcomponents/common/interface/bindingsdirectly. - Updated Stencil-generated typings (
components.d.ts) to remove the deleted Stencil date-input component type entries.
Reviewed changes
Copilot reviewed 109 out of 110 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/atomic/src/utils/jsx-utils.tsx | Removed deprecated Stencil-only LocalizedString helper. |
| packages/atomic/src/utils/accessibility-utils.ts | Updated AnyBindings import to the new source module. |
| packages/atomic/src/decorators/bindings.ts | Updated AnyBindings import to the new source module. |
| packages/atomic/src/components/search/result-template-components/quickview-iframe/stencil-quickview-iframe.tsx | Removed deprecated Stencil functional component implementation. |
| packages/atomic/src/components/search/facets/facet-segmented-value/stencil-facet-segmented-value.tsx | Removed deprecated Stencil functional component implementation. |
| packages/atomic/src/components/common/suggestions/stencil-query-suggestions.tsx | Removed deprecated Stencil functional component implementation(s). |
| packages/atomic/src/components/common/suggestions/stencil-instant-item.tsx | Removed deprecated Stencil functional component implementation(s). |
| packages/atomic/src/components/common/stencil-triStateCheckbox.tsx | Removed deprecated Stencil functional component implementation. |
| packages/atomic/src/components/common/stencil-switch.tsx | Removed deprecated Stencil functional component implementation. |
| packages/atomic/src/components/common/stencil-radio-button.tsx | Removed deprecated Stencil functional component implementation. |
| packages/atomic/src/components/common/stencil-checkbox.tsx | Removed deprecated Stencil functional component implementation. |
| packages/atomic/src/components/common/stencil-carousel.tsx | Removed deprecated Stencil functional component implementation. |
| packages/atomic/src/components/common/smart-snippets/stencil-smart-snippet-feedback-banner.tsx | Removed deprecated Stencil functional component implementation. |
| packages/atomic/src/components/common/smart-snippets/atomic-smart-snippet/stencil-smart-snippet-common.tsx | Removed deprecated Stencil functional component implementation(s). |
| packages/atomic/src/components/common/smart-snippets/atomic-smart-snippet-suggestions/stencil-smart-snippet-suggestions-common.tsx | Removed deprecated Stencil functional component implementation(s). |
| packages/atomic/src/components/common/smart-snippets/atomic-smart-snippet-feedback-modal/stencil-smart-snippet-feedback-modal-common.tsx | Removed deprecated Stencil functional component implementation(s) + constants. |
| packages/atomic/src/components/common/search-box/stencil-text-area-clear-button.tsx | Removed deprecated Stencil functional component implementation. |
| packages/atomic/src/components/common/search-box/stencil-submit-button.tsx | Removed deprecated Stencil functional component implementation. |
| packages/atomic/src/components/common/search-box/stencil-search-text-area.tsx | Removed deprecated Stencil functional component implementation. |
| packages/atomic/src/components/common/search-box/stencil-search-box-wrapper.tsx | Removed deprecated Stencil functional component implementation. |
| packages/atomic/src/components/common/result-children/stencil-show-hide-button.tsx | Removed deprecated Stencil functional component implementation. |
| packages/atomic/src/components/common/result-children/stencil-guard.tsx | Removed deprecated Stencil functional component implementation. |
| packages/atomic/src/components/common/result-children/stencil-collection-guard.tsx | Removed deprecated Stencil functional component implementation. |
| packages/atomic/src/components/common/result-children/stencil-children-wrapper.tsx | Removed deprecated Stencil functional component implementation. |
| packages/atomic/src/components/common/refine-modal/stencil-sort.tsx | Removed deprecated Stencil functional component implementation. |
| packages/atomic/src/components/common/refine-modal/stencil-modal.tsx | Removed deprecated Stencil functional component implementation. |
| packages/atomic/src/components/common/refine-modal/stencil-guard.tsx | Removed deprecated Stencil functional component implementation. |
| packages/atomic/src/components/common/refine-modal/stencil-filters.tsx | Removed deprecated Stencil functional component implementation(s). |
| packages/atomic/src/components/common/refine-modal/stencil-button.tsx | Removed deprecated Stencil functional component implementation. |
| packages/atomic/src/components/common/refine-modal/stencil-body.tsx | Removed deprecated Stencil functional component implementation. |
| packages/atomic/src/components/common/query-summary/stencil-utils.tsx | Removed deprecated Stencil query-summary utilities. |
| packages/atomic/src/components/common/query-summary/stencil-guard.tsx | Removed deprecated Stencil functional component implementation. |
| packages/atomic/src/components/common/query-summary/stencil-container.tsx | Removed deprecated Stencil functional component implementation. |
| packages/atomic/src/components/common/query-error/stencil-title.tsx | Removed deprecated Stencil functional component implementation. |
| packages/atomic/src/components/common/query-error/stencil-show-more.tsx | Removed deprecated Stencil functional component implementation. |
| packages/atomic/src/components/common/query-error/stencil-link.tsx | Removed deprecated Stencil functional component implementation. |
| packages/atomic/src/components/common/query-error/stencil-icon.tsx | Removed deprecated Stencil functional component implementation. |
| packages/atomic/src/components/common/query-error/stencil-guard.tsx | Removed deprecated Stencil functional component implementation. |
| packages/atomic/src/components/common/query-error/stencil-details.tsx | Removed deprecated Stencil functional component implementation. |
| packages/atomic/src/components/common/query-error/stencil-description.tsx | Removed deprecated Stencil functional component implementation. |
| packages/atomic/src/components/common/query-error/stencil-container.tsx | Removed deprecated Stencil functional component implementation. |
| packages/atomic/src/components/common/query-correction/stencil-trigger-correction.tsx | Removed deprecated Stencil functional component implementation. |
| packages/atomic/src/components/common/query-correction/stencil-guard.tsx | Removed deprecated Stencil functional component implementation. |
| packages/atomic/src/components/common/query-correction/stencil-correction.tsx | Removed deprecated Stencil functional component implementation. |
| packages/atomic/src/components/common/query-correction/stencil-auto-correction.tsx | Removed deprecated Stencil functional component implementation. |
| packages/atomic/src/components/common/product-template/stencil-product-template-common.tsx | Removed deprecated Stencil product-template helper class/utilities. |
| packages/atomic/src/components/common/pager/stencil-pager-navigation.tsx | Removed deprecated Stencil functional component implementation. |
| packages/atomic/src/components/common/pager/stencil-pager-buttons.tsx | Removed deprecated Stencil functional component implementation(s). |
| packages/atomic/src/components/common/no-items/stencil-tips.tsx | Removed deprecated Stencil functional component implementation. |
| packages/atomic/src/components/common/no-items/stencil-no-items.tsx | Removed deprecated Stencil functional component implementation. |
| packages/atomic/src/components/common/no-items/stencil-magnifying-glass.tsx | Removed deprecated Stencil functional component implementation. |
| packages/atomic/src/components/common/no-items/stencil-guard.tsx | Removed deprecated Stencil functional component implementation. |
| packages/atomic/src/components/common/no-items/stencil-container.tsx | Removed deprecated Stencil functional component implementation. |
| packages/atomic/src/components/common/load-more/stencil-summary.tsx | Removed deprecated Stencil functional component implementation. |
| packages/atomic/src/components/common/load-more/stencil-progress-bar.tsx | Removed deprecated Stencil functional component implementation. |
| packages/atomic/src/components/common/load-more/stencil-container.tsx | Removed deprecated Stencil functional component implementation. |
| packages/atomic/src/components/common/load-more/stencil-button.tsx | Removed deprecated Stencil functional component implementation. |
| packages/atomic/src/components/common/load-more/guard.tsx | Removed deprecated Stencil functional component implementation. |
| packages/atomic/src/components/common/item-text/stencil-item-text-highlighted.tsx | Removed deprecated Stencil functional component implementation. |
| packages/atomic/src/components/common/item-text/stencil-item-text-fallback.tsx | Removed deprecated Stencil functional component implementation. |
| packages/atomic/src/components/common/item-list/stencil-item-list-guard.tsx | Removed deprecated Stencil functional component implementation. |
| packages/atomic/src/components/common/item-list/stencil-item-list-common.tsx | Removed deprecated Stencil item-list common class implementation. |
| packages/atomic/src/components/common/item-list/stencil-item-display-guard.tsx | Removed deprecated Stencil functional component implementation. |
| packages/atomic/src/components/common/item-list/stencil-display-wrapper.tsx | Removed deprecated Stencil functional component implementation(s). |
| packages/atomic/src/components/common/item-list/stencil-display-grid.tsx | Removed deprecated Stencil functional component implementation. |
| packages/atomic/src/components/common/item-list/item-list-decorators.tsx | Removed deprecated Stencil decorators for folded item lists. |
| packages/atomic/src/components/common/item-link/stencil-item-link.tsx | Removed deprecated Stencil link helper implementation. |
| packages/atomic/src/components/common/item-link/attributes-slot.spec.tsx | Removed unit test file for attributes-slot utility. |
| packages/atomic/src/components/common/generated-answer/stencil-source-citations.tsx | Removed deprecated Stencil generated-answer helper implementation. |
| packages/atomic/src/components/common/generated-answer/stencil-show-button.tsx | Removed deprecated Stencil generated-answer helper implementation. |
| packages/atomic/src/components/common/generated-answer/stencil-retry-prompt.tsx | Removed deprecated Stencil generated-answer helper implementation. |
| packages/atomic/src/components/common/generated-answer/stencil-generated-content-container.tsx | Removed deprecated Stencil generated-answer helper implementation. |
| packages/atomic/src/components/common/generated-answer/stencil-feedback-button.tsx | Removed deprecated Stencil generated-answer helper implementation. |
| packages/atomic/src/components/common/generated-answer/stencil-copy-button.tsx | Removed deprecated Stencil generated-answer helper implementation. |
| packages/atomic/src/components/common/generated-answer/generated-content/stencil-generated-text-content.tsx | Removed deprecated Stencil generated-answer helper implementation. |
| packages/atomic/src/components/common/generated-answer/generated-content/stencil-generated-markdown-content.tsx | Removed deprecated Stencil generated-answer helper implementation. |
| packages/atomic/src/components/common/generated-answer/generated-answer-common.tsx | Removed deprecated Stencil generated-answer common class implementation. |
| packages/atomic/src/components/common/facets/stencil-facet-guard.tsx | Removed deprecated Stencil facet guard helper implementation. |
| packages/atomic/src/components/common/facets/stencil-facet-date-input/stencil-facet-date-input.tsx | Removed deprecated atomic-stencil-facet-date-input Stencil component implementation. |
| packages/atomic/src/components/common/facets/numeric-facet/stencil-values-container.tsx | Removed deprecated Stencil functional component implementation. |
| packages/atomic/src/components/common/facets/numeric-facet/stencil-value-link.tsx | Removed deprecated Stencil functional component implementation. |
| packages/atomic/src/components/common/facets/facet-value/stencil-facet-value.tsx | Removed deprecated Stencil functional component implementation. |
| packages/atomic/src/components/common/facets/facet-value-exclude/stencil-facet-value-exclude.tsx | Removed deprecated Stencil functional component implementation. |
| packages/atomic/src/components/common/facets/facet-value-checkbox/stencil-facet-value-checkbox.tsx | Removed deprecated Stencil functional component implementation. |
| packages/atomic/src/components/common/facets/facet-value-box/stencil-facet-value-box.tsx | Removed deprecated Stencil functional component implementation. |
| packages/atomic/src/components/common/facets/facet-show-more-less/stencil-facet-show-more-less.tsx | Removed deprecated Stencil functional component implementation. |
| packages/atomic/src/components/common/facets/facet-search/stencil-facet-search-value.tsx | Removed deprecated Stencil functional component implementation. |
| packages/atomic/src/components/common/facets/facet-search/stencil-facet-search-matches.tsx | Removed deprecated Stencil functional component implementation. |
| packages/atomic/src/components/common/facets/facet-search/stencil-facet-search-input.tsx | Removed deprecated Stencil functional component implementation. |
| packages/atomic/src/components/common/facets/facet-search/stencil-facet-search-input-guard.tsx | Removed deprecated Stencil functional component implementation. |
| packages/atomic/src/components/common/facets/category-facet/stencil-value-link.tsx | Removed deprecated Stencil functional component implementation. |
| packages/atomic/src/components/common/facets/category-facet/stencil-value-as-tree-container.tsx | Removed deprecated Stencil functional component implementation. |
| packages/atomic/src/components/common/facets/category-facet/stencil-search-value.tsx | Removed deprecated Stencil functional component implementation. |
| packages/atomic/src/components/common/facets/category-facet/stencil-search-results-container.tsx | Removed deprecated Stencil functional component implementation. |
| packages/atomic/src/components/common/facets/category-facet/stencil-parent-value-link.tsx | Removed deprecated Stencil functional component implementation. |
| packages/atomic/src/components/common/facets/category-facet/stencil-parent-button.tsx | Removed deprecated Stencil functional component implementation. |
| packages/atomic/src/components/common/facets/category-facet/stencil-parent-as-tree-container.tsx | Removed deprecated Stencil functional component implementation. |
| packages/atomic/src/components/common/facets/category-facet/stencil-children-as-tree-container.tsx | Removed deprecated Stencil functional component implementation. |
| packages/atomic/src/components/common/facets/category-facet/stencil-child-value-link.tsx | Removed deprecated Stencil functional component implementation. |
| packages/atomic/src/components/common/facets/category-facet/stencil-all-categories-button.tsx | Removed deprecated Stencil functional component implementation. |
| packages/atomic/src/components/common/context/bindings-context.ts | Updated AnyBindings import path. |
| packages/atomic/src/components/common/breadbox/stencil-breadcrumb-show-more.tsx | Removed deprecated Stencil functional component implementation. |
| packages/atomic/src/components/common/breadbox/stencil-breadcrumb-show-less.tsx | Removed deprecated Stencil functional component implementation. |
| packages/atomic/src/components/common/breadbox/stencil-breadcrumb-content.tsx | Removed deprecated Stencil functional component implementation. |
| packages/atomic/src/components/common/breadbox/stencil-breadcrumb-container.tsx | Removed deprecated Stencil functional component implementation. |
| packages/atomic/src/components/common/breadbox/stencil-breadcrumb-clear-all.tsx | Removed deprecated Stencil functional component implementation. |
| packages/atomic/src/components/common/breadbox/stencil-breadcrumb-button.tsx | Removed deprecated Stencil functional component implementation. |
| packages/atomic/src/components/common/atomic-result-placeholder/stencil-placeholders.tsx | Removed deprecated Stencil placeholder helpers. |
| packages/atomic/src/components/common/atomic-rating/stencil-rating.tsx | Removed deprecated Stencil rating helper + star computation. |
| packages/atomic/src/components.d.ts | Updated Stencil-generated typings to remove deleted exports/components. |
Comments suppressed due to low confidence (2)
packages/atomic/src/components/common/item-link/attributes-slot.spec.tsx:1
getAttributesFromLinkSlotContent(inpackages/atomic/src/components/common/item-link/attributes-slot.ts) is still used by multiple components, but this PR removes its only dedicated unit test file. Unless this logic is covered elsewhere, this is a test coverage regression; consider migrating the test to Vitest instead of deleting it.
packages/atomic/src/components/search/result-template-components/quickview-iframe/stencil-quickview-iframe.tsx:1- This file is removed, but
packages/atomic/src/components/search/result-template-components/quickview-iframe/stencil-quickview-iframe.spec.tsstill imports./stencil-quickview-iframe(and the directory now only contains the Litquickview-iframe.ts). The test suite will fail to compile unless the spec is deleted or updated to test the LitrenderQuickviewIframehelper instead.
louis-bompart
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
louis-bompart
force-pushed
the
spring-is-coming-vol1
branch
from
4b06fbe to
8e7c40b
Compare
louis-bompart
temporarily deployed
to
pr-workflows
GitHub Actions
Inactive
louis-bompart
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
louis-bompart
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
louis-bompart
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
louis-bompart
temporarily deployed
to
Prerelease (CDN)
GitHub Actions
Inactive
louis-bompart
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
louis-bompart
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
fbeaudoincoveo
approved these changes
Feb 26, 2026
Contributor
fbeaudoincoveo
left a comment
fbeaudoincoveo
left a comment
There was a problem hiding this comment.
Approved, but don't forget to undo the attributes-slot.spec.tsx deletion (should be converted into vitest / .ts and kept; can be done in another PR).
Contributor
There was a problem hiding this comment.
I'm not sure this one should be removed; attributes-slot.ts is still there and being used.
However if should definitely be converted to Vitest.
| @@ -1,5 +1,5 @@ | |||
| import {ContextRoot, createContext} from '@lit/context'; | |||
| import type {AnyBindings} from '@/src/components'; | |||
| import type {AnyBindings} from '../interface/bindings'; | |||
Contributor
There was a problem hiding this comment.
No no no, use a path alias 😁
| import type {ReactiveController, ReactiveControllerHost} from 'lit'; | ||
| import type {AnyBindings} from '../components'; | ||
| import type {AtomicAriaLive} from '../components/common/atomic-aria-live/atomic-aria-live'; | ||
| import type {AnyBindings} from '../components/common/interface/bindings'; |
| import type {ReactiveElement} from 'lit'; | ||
| import type {AnyBindings} from '../components'; | ||
| import {bindingsContext} from '../components/common/context/bindings-context'; | ||
| import type {AnyBindings} from '../components/common/interface/bindings'; |
louis-bompart
commented
Feb 26, 2026
Collaborator
Author
louis-bompart
left a comment
louis-bompart
left a comment
There was a problem hiding this comment.
@copilot fix this
| import type {ReactiveElement} from 'lit'; | ||
| import type {AnyBindings} from '../components'; | ||
| import {bindingsContext} from '../components/common/context/bindings-context'; | ||
| import type {AnyBindings} from '../components/common/interface/bindings'; |
| import type {ReactiveController, ReactiveControllerHost} from 'lit'; | ||
| import type {AnyBindings} from '../components'; | ||
| import type {AtomicAriaLive} from '../components/common/atomic-aria-live/atomic-aria-live'; | ||
| import type {AnyBindings} from '../components/common/interface/bindings'; |
| @@ -1,5 +1,5 @@ | |||
| import {ContextRoot, createContext} from '@lit/context'; | |||
| import type {AnyBindings} from '@/src/components'; | |||
| import type {AnyBindings} from '../interface/bindings'; | |||
Contributor
|
@louis-bompart I've opened a new pull request, #7181, to work on those changes. Once the pull request is ready, I'll request review from you. |
11 tasks
#7181) Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: louis-bompart <12366410+louis-bompart@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.