deps: update to cosmos-sdk v0.52 (Olympus) #7261

tac0turtle · 2024-09-06T10:33:45Z

Description

@damiannolan updating PR description.

Updates ibc-go to cosmos-sdk olympus release.

We will also migrate to use runtime.Environment. Currently this PR only migrates icacontroller to runtime.Environment to fix test failures which suffered from loss of event propagation when using UnwrapSDKContext due to event emission on a copy.

Blocking issues:

** Required for compatability tests and E2E upgrade tests as client code working on v0.52 is incompatible against older node software

closes: #7223

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

DimitrisJim · 2024-12-17T09:43:11Z

modules/apps/27-interchain-accounts/host/keeper/relay_test.go

@@ -641,7 +641,7 @@ func (suite *KeeperTestSuite) TestJSONOnRecvPacket() {
 							"messages": [],
 							"metadata": "ipfs://CID",
 							"title": "IBC Gov Proposal",
-							"summary": "tokens for all!",
+							"summary": "tokens for some, miniature American flags for others!",


lol'ed profusely

modules/apps/27-interchain-accounts/module.go

DimitrisJim

more than half way there, looks great so far!

modules/apps/transfer/keeper/relay_test.go

modules/apps/transfer/module.go

modules/apps/27-interchain-accounts/module.go

modules/apps/transfer/keeper/genesis.go

sonarqubecloud · 2024-12-17T10:21:35Z

Quality Gate passed for 'ibc-go'

Issues
146 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

DimitrisJim

finished all files. Idea of merging and taking care of some things post merge sounds good to me.

Thanks so much @tac0turtle for initial work and @damiannolan and @chatton for powering through with it!

modules/core/keeper/msg_server.go

modules/light-clients/07-tendermint/update.go

modules/light-clients/07-tendermint/update_test.go

modules/light-clients/08-wasm/keeper/keeper.go

DimitrisJim · 2024-12-17T11:01:59Z

modules/light-clients/08-wasm/testing/simapp/ante_handler.go

 		ante.NewValidateMemoDecorator(options.AccountKeeper),
 		ante.NewConsumeGasForTxSizeDecorator(options.AccountKeeper),
 		ante.NewDeductFeeDecorator(options.AccountKeeper, options.BankKeeper, options.FeegrantKeeper, options.TxFeeChecker),
-		ante.NewSetPubKeyDecorator(options.AccountKeeper), // SetPubKeyDecorator must be called before all signature verification decorators


trusting this comment is still valid and handled by the new NewSigVerificationDecorator handler that appears to encompass all ones that are now removed

I think so! But I didn't verify

testing/simapp/ante.go

damiannolan

Happy to move forward with this to main now. I've created a number of issues to follow up with and I will continue migrating the rest of the codebase to use appmodule.Environment

Thanks to everyone who contributed on this PR and to the SDK team for their responsiveness in addressing any issues that came up from it.

The last blocking issue listed in the description is in relation to client encoding of txs which directly affects testing compatibility and upgrade tests. This is being actively worked on and I think it can be resolved soon ™️

edit: note that build (arm) was removed but is still showing as a required check on PR. This doesn't matter anymore

damiannolan · 2024-12-17T11:38:27Z

.golangci.yml

This could use more love too at some point

DimitrisJim · 2024-12-17T12:16:49Z

edit: note that build (arm) was removed but is still showing as a required check on PR. This doesn't matter anymore

removed as required check!

gjermundgaraba

Holy moly this was not a small upgrade 🙈
Really great work on this! LGTM and follow up with smaller PRs as soon as possible.

gjermundgaraba · 2024-12-17T11:34:27Z

e2e/testsuite/testsuite.go

@@ -42,7 +42,7 @@ const (
 	// ChainBRelayerName is the name given to the relayer wallet on ChainB
 	ChainBRelayerName = "rlyB"
 	// DefaultGasValue is the default gas value used to configure tx.Factory
-	DefaultGasValue = 500_000_0000
+	DefaultGasValue = 100_000_00


yeah, would be interesting to understand if this is because it was sent too high in the first place, or the sdk somehow requires less? Not very important if this value works (although, should it not be 10_000_000? :D )

modules/apps/27-interchain-accounts/module.go

modules/apps/transfer/keeper/keeper.go

This reverts commit 8575743.

* Revert "chore: bump to sdk v0.52-rc.2 (#7882)" This reverts commit 4e54444. * Revert "chore: clean up module impls (#7865)" This reverts commit d91eb00. * Revert "fix: sanitize gov v1 proposal in e2e tests for compatibility with 0.52 (#7861)" This reverts commit 39b190a. * Revert "chore: bump sdk versions (#7843)" This reverts commit c29c1ab. * Revert "fix: wasm docker file + wasm simapp gas limit (#7830)" This reverts commit 7f0cf54. * Revert "chore: use header service in localhost client (#7757)" This reverts commit 0bea84d. * Revert "refactor: ibc core runtime env (#7601)" This reverts commit f5e1a4c. * Revert "refactor: use branch service in 29-fee (#7732)" This reverts commit d50f7ba. * Revert "chore: address some linter complaints (#7734)" This reverts commit 83fdb7f. * Revert "chore: refactor event service to 29-fee (#7728)" This reverts commit 0b2866d. * Revert "refactor: update 29-fee to use runtime.Environment (#7617)" This reverts commit c8dc02c. * Revert "refactor: use event service in transfer mod (#7725)" This reverts commit 0e72d08. * Revert "refactor: update transfer to use runtime.Environment (#7615)" This reverts commit fd6a78a. * Revert "Remove circuit module (#7715)" This reverts commit 39d8547. * Revert "refactor: use header info for interchain accounts address generation (#7713)" This reverts commit c15bb5c. * Revert "refactor: update icahost to use runtime.Environment (#7600)" This reverts commit 7aae649. * Revert "chore: update import alias to align (#7710)" This reverts commit a14feef. * Revert "deps: update to cosmos-sdk v0.52 (Olympus) (#7261)" This reverts commit 8575743. * fix unwanted reverts * remove invariant * lint * last go1.23 change * remove unecessary testing keeper * update go version in dockerfile * fix docker image

tac0turtle added 10 commits September 6, 2024 12:33

go mod changes

a1ef65e

remove cometabci direct dep

a0bf113

fix all errors

5a331ed

appmodule & simapp cleanup

6d49de2

08wasm fixes

ad88b3c

get 08-wasm compiling

fec6f52

another simapp

fc0f25a

another simapp

3e5029e

pass in environment

10440c8

fix compilation errors

d779d86

tac0turtle changed the title ~~chore: update to 0.52 (1/n)~~ chore: update to 0.52 Sep 8, 2024

tac0turtle added 3 commits September 9, 2024 11:30

some fixes

2a11f2e

build

d029e19

fix other simapps

c055483

Reecepbcups mentioned this pull request Sep 9, 2024

Update to SDK v0.52 / IBC v10 strangelove-ventures/interchaintest#1251

Open

tac0turtle added 3 commits September 9, 2024 18:32

linting

26d765e

remove unsed code

2ee5548

Merge branch 'feat/upgrade-sdk-v0.52' into marko/gomod_change

0832575

tac0turtle force-pushed the marko/gomod_change branch from 2bb67b5 to 0832575 Compare September 23, 2024 10:07

tac0turtle added 11 commits September 23, 2024 13:08

go mod changes

11e5c51

add pool module

db4ab33

anothersimapp

da38c64

linting fixes

455a2e8

protocol pool module accounts

471123e

callback fixes

8c99de3

simapp fixes

c01a5ed

register interfaces

16d4530

fix feeibc

ab2191b

changes++

4a5d564

Merge branch 'feat/upgrade-sdk-v0.52' into marko/gomod_change

b2978bb

damiannolan added 8 commits December 16, 2024 15:24

chore: readd TestABCICodeDeterminism to 04-channel types

6dc1572

refactor: remove redundant AppModuleBasics

57cb8e8

chore: rm GetStakingKeeper api from testing app

de75d2c

chore: update version in wasm dockerfile

6dd955d

chore: update the go work example file version

d4644d0

chore: rm UnwrapSDKContext in ica where possible

4513f7f

Merge branch 'main' into marko/gomod_change

6d5937c

fix: import path in e2e from suggestion

3d9ad80

DimitrisJim reviewed Dec 17, 2024

View reviewed changes

modules/apps/27-interchain-accounts/module.go Show resolved Hide resolved

Merge branch 'main' into marko/gomod_change

efca310

DimitrisJim reviewed Dec 17, 2024

View reviewed changes

modules/apps/transfer/keeper/relay_test.go Show resolved Hide resolved

modules/apps/transfer/module.go Show resolved Hide resolved

modules/apps/27-interchain-accounts/module.go Show resolved Hide resolved

modules/apps/transfer/keeper/genesis.go Show resolved Hide resolved

This was referenced Dec 17, 2024

Propagate errors in favour of panicking in genesis funcs (v0.52/olympus) #7698

Open

Migration path for math.IntProto to math.Int (breaking) #7699

Open

DimitrisJim approved these changes Dec 17, 2024

View reviewed changes

This was referenced Dec 17, 2024

Potentially remove circuit module from testing simapp #7700

Closed

Fulfil only necessary interfaces in each module's module.go #7701

Closed

Consistently name context variable #7702

Open

damiannolan approved these changes Dec 17, 2024

View reviewed changes

.golangci.yml

Copy link

Contributor

damiannolan Dec 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could use more love too at some point

gjermundgaraba approved these changes Dec 17, 2024

View reviewed changes

damiannolan added this pull request to the merge queue Dec 17, 2024

Merged via the queue into main with commit 8575743 Dec 17, 2024
119 of 129 checks passed

damiannolan deleted the marko/gomod_change branch December 17, 2024 15:50

DimitrisJim mentioned this pull request Dec 19, 2024

chore: miscellaneous for v0.52 to compile #7298

Closed

10 tasks

gjermundgaraba added a commit that referenced this pull request Feb 7, 2025

Revert "deps: update to cosmos-sdk v0.52 (Olympus) (#7261)"

80a9b2e

This reverts commit 8575743.

gjermundgaraba added a commit that referenced this pull request Feb 7, 2025

Revert "deps: update to cosmos-sdk v0.52 (Olympus) (#7261)"

38eb116

This reverts commit 8575743.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

deps: update to cosmos-sdk v0.52 (Olympus) #7261

deps: update to cosmos-sdk v0.52 (Olympus) #7261

tac0turtle commented Sep 6, 2024 •

edited by damiannolan

Loading

DimitrisJim Dec 17, 2024 •

edited

Loading

DimitrisJim left a comment

sonarqubecloud bot commented Dec 17, 2024

DimitrisJim left a comment

DimitrisJim Dec 17, 2024

damiannolan Dec 17, 2024

damiannolan left a comment •

edited

Loading

damiannolan Dec 17, 2024

DimitrisJim commented Dec 17, 2024

gjermundgaraba left a comment

gjermundgaraba Dec 17, 2024

deps: update to cosmos-sdk v0.52 (Olympus) #7261

deps: update to cosmos-sdk v0.52 (Olympus) #7261

Conversation

tac0turtle commented Sep 6, 2024 • edited by damiannolan Loading

Description

DimitrisJim Dec 17, 2024 • edited Loading

Choose a reason for hiding this comment

DimitrisJim left a comment

Choose a reason for hiding this comment

sonarqubecloud bot commented Dec 17, 2024

Quality Gate passed for 'ibc-go'

DimitrisJim left a comment

Choose a reason for hiding this comment

DimitrisJim Dec 17, 2024

Choose a reason for hiding this comment

damiannolan Dec 17, 2024

Choose a reason for hiding this comment

damiannolan left a comment • edited Loading

Choose a reason for hiding this comment

damiannolan Dec 17, 2024

Choose a reason for hiding this comment

DimitrisJim commented Dec 17, 2024

gjermundgaraba left a comment

Choose a reason for hiding this comment

gjermundgaraba Dec 17, 2024

Choose a reason for hiding this comment

tac0turtle commented Sep 6, 2024 •

edited by damiannolan

Loading

DimitrisJim Dec 17, 2024 •

edited

Loading

damiannolan left a comment •

edited

Loading