Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propagate errors in favour of panicking in genesis funcs (v0.52/olympus) #7698

Open
damiannolan opened this issue Dec 17, 2024 · 5 comments
Open

Propagate errors in favour of panicking in genesis funcs (v0.52/olympus) #7698

damiannolan opened this issue Dec 17, 2024 · 5 comments
Labels
good first issue Good for newcomers icebox Issues that we will not address for the time being type: code hygiene Clean up code but without changing functionality or interfaces

Comments

@damiannolan
Copy link
Contributor

Remove panic calls from genesis funcs in ibc.

We can now propagate errors and let them be handled gracefully from cosmos-sdk in genesis funcs.

Pending #7261

do we want to update sig to return error here too? Most of functions invoked in here currently go the ol' panic route in most cases. Does sdk panic on returned error during genesis ops?

Originally posted by @DimitrisJim in #7261 (comment)
@damiannolan damiannolan added the type: code hygiene Clean up code but without changing functionality or interfaces label Dec 17, 2024
@damiannolan damiannolan added this to the v10.0.0 milestone Dec 17, 2024
@damiannolan damiannolan mentioned this issue Dec 17, 2024
Merged
10 tasks
@Sruthi2357
Copy link
Contributor

Shall I work on this?

@gjermundgaraba
Copy link
Contributor

Are you still interested in working on this @Sruthi2357?

@gjermundgaraba gjermundgaraba added the good first issue Good for newcomers label Jan 11, 2025
@Sruthi2357
Copy link
Contributor

yes @gjermundgaraba

@gjermundgaraba
Copy link
Contributor

Great, I've assigned it to you. Feel free to open a PR for this when you get a chance :)

@crStiv crStiv mentioned this issue Feb 6, 2025
Closed
@gjermundgaraba gjermundgaraba removed this from the v10.0.0 milestone Feb 6, 2025
@gjermundgaraba
Copy link
Contributor

We've decided to hold off on this work as 0.52 has just been put on hold. I am very sorry for the inconvenience.

@gjermundgaraba gjermundgaraba added the icebox Issues that we will not address for the time being label Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers icebox Issues that we will not address for the time being type: code hygiene Clean up code but without changing functionality or interfaces
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(genesis): improve error handling by removing panics crStiv/ibc-go
3 participants
@gjermundgaraba @damiannolan @Sruthi2357