refactor: migrate compose cosign verify test to nerdtest - #5120
Open
ogulcanaydogan wants to merge 1 commit into
Open
refactor: migrate compose cosign verify test to nerdtest#5120ogulcanaydogan wants to merge 1 commit into
ogulcanaydogan wants to merge 1 commit into
Conversation
ogulcanaydogan
force-pushed
the
refactor/migrate-compose-cosign-nerdtest
branch
2 times, most recently
from
August 3, 2026 13:14
8e96072 to
00f6414
Compare
Member
|
https://github.com/containerd/nerdctl/actions/runs/30817082009/job/91698615916?pr=5120 |
ogulcanaydogan
force-pushed
the
refactor/migrate-compose-cosign-nerdtest
branch
from
August 4, 2026 09:17
00f6414 to
c5e7c34
Compare
46 tasks
ogulcanaydogan
force-pushed
the
refactor/migrate-compose-cosign-nerdtest
branch
from
August 4, 2026 10:12
c5e7c34 to
4d9ff3c
Compare
AkihiroSuda
reviewed
Aug 4, 2026
| helpers.Ensure("compose", "-f", composePath, "push") | ||
| } | ||
|
|
||
| testCase.Cleanup = func(data test.Data, helpers test.Helpers) { |
Member
There was a problem hiding this comment.
composeRunCleanup should be used after merging #5116
https://github.com/containerd/nerdctl/pull/5116/changes#diff-637fd446eaba2f5e95eb133b88283df22684871caf9282a101bde09dc1858ff1R42
Contributor
Author
Contributor
Author
There was a problem hiding this comment.
Done, #5116 landed so I rebased and switched both the subtest and top-level cleanups to composeRunCleanup(). Thanks!
Migrate TestComposePushAndPullWithCosignVerify from testutil.NewBase to nerdtest.Setup, the last remaining file in the nerdtest migration (containerd#4613). Uses nerdtest.RegistryWithNoAuth and nerdtest.GenerateCosignKeyPair, and WithPseudoTTY in place of the unbuffer helper for the tty runs. Signed-off-by: Ogulcan Aydogan <ogulcanaydogan@gmail.com>
ogulcanaydogan
force-pushed
the
refactor/migrate-compose-cosign-nerdtest
branch
from
August 5, 2026 12:21
4d9ff3c to
261b102
Compare
opjt
approved these changes
Aug 7, 2026
Contributor
Author
|
Thanks for catching that. The TestComposePushAndPullWithCosignVerify failure is fixed in the latest push and CI is green now. Ready for another look when you have time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrates
TestComposePushAndPullWithCosignVerifyfromtestutil.NewBasetonerdtest.Setup, the last remaining file in the nerdtest migration (#4613).nerdtest.RegistryWithNoAuthandnerdtest.GenerateCosignKeyPair.unbufferhelper withWithPseudoTTY()for the tty runs.Tested on Ubuntu with containerd, buildkit and cosign. All 9 subtests pass, including the key-mismatch cases that must fail.