Rewrite tests using `testutil.NewBase` to use `nerdtest.Setup` (Tigron)

[AkihiroSuda]

All the tests using testutil.NewBase should be rewritten to use nerdtest.Setup (i.e., Tigron framework)

https://github.com/search?q=repo%3Acontainerd%2Fnerdctl%20testutil.NewBase&type=code
https://github.com/search?q=repo%3Acontainerd%2Fnerdctl+nerdtest.Setup&type=code

Example occurrence:

nerdctl/cmd/nerdctl/container/container_list_test.go

Lines 27 to 62 in 1d69ed9

	// https://github.com/containerd/nerdctl/issues/2598
	func TestContainerListWithFormatLabel(t *testing.T) {
	t.Parallel()
	base := testutil.NewBase(t)
	tID := testutil.Identifier(t)
	cID := tID
	labelK := "label-key-" + tID
	labelV := "label-value-" + tID
	base.Cmd("run", "-d",
	"--name", cID,
	"--label", labelK+"="+labelV,
	testutil.CommonImage, "sleep", nerdtest.Infinity).AssertOK()
	defer base.Cmd("rm", "-f", cID).AssertOK()
	base.Cmd("ps", "-a",
	"--filter", "label="+labelK,
	"--format", fmt.Sprintf("{{.Label %q}}", labelK)).AssertOutExactly(labelV + "\n")
	}
	func TestContainerListWithJsonFormatLabel(t *testing.T) {
	t.Parallel()
	base := testutil.NewBase(t)
	tID := testutil.Identifier(t)
	cID := tID
	labelK := "label-key-" + tID
	labelV := "label-value-" + tID
	base.Cmd("run", "-d",
	"--name", cID,
	"--label", labelK+"="+labelV,
	testutil.CommonImage, "sleep", nerdtest.Infinity).AssertOK()
	defer base.Cmd("rm", "-f", cID).AssertOK()
	base.Cmd("ps", "-a",
	"--filter", "label="+labelK,
	"--format", "json").AssertOutContains(fmt.Sprintf("%s=%s", labelK, labelV))
	}

Example PR:

• Refactor container_list_test.go to use Tigron #4641

Similar PRs:

• [CI]: rewrite TestRunBindMountBind #4145

This is a "good first issue", but needs a bunch of PRs.

---

Important

It is highly recommended to begin with updating a single short file.

Files (46)

• https://github.com/containerd/nerdctl/blob/main/cmd/nerdctl/compose/compose_create_linux_test.go test: refactor compose_create_linux_test.go to use Tigron #4670
• https://github.com/containerd/nerdctl/blob/main/cmd/nerdctl/compose/compose_down_linux_test.go test: refactor compose_down_linux_test.go to use Tigron #4672
• https://github.com/containerd/nerdctl/blob/main/cmd/nerdctl/compose/compose_kill_linux_test.go test: refactor compose_kill_linux_test.go to use Tigron #4676
• https://github.com/containerd/nerdctl/blob/main/cmd/nerdctl/compose/compose_pause_linux_test.go test: refactor compose_pause_linux_test.go to use Tigron #4688
• https://github.com/containerd/nerdctl/blob/main/cmd/nerdctl/compose/compose_port_linux_test.go test: refactor compose_port_linux_test.go to use Tigron #4713
• https://github.com/containerd/nerdctl/blob/main/cmd/nerdctl/compose/compose_ps_linux_test.go test: refactor compose_ps_linux_test.go to use tigron #4790
• https://github.com/containerd/nerdctl/blob/main/cmd/nerdctl/compose/compose_pull_linux_test.go test: refactor compose_pull_linux_test.go to use nerdtest/tigron #4796
• https://github.com/containerd/nerdctl/blob/main/cmd/nerdctl/compose/compose_restart_linux_test.go compose_linux_restart test refactor #4834
• https://github.com/containerd/nerdctl/blob/main/cmd/nerdctl/compose/compose_run_linux_test.go Refactor compose_run_linux_test #4845 test: convert compose run linux test to Tigron framework #5094 refactor: migrate compose cosign verify test to nerdtest #5120
• https://github.com/containerd/nerdctl/blob/main/cmd/nerdctl/compose/compose_up_linux_test.go test: refactor compose_up_linux_test.go to use Tigron #4654
• https://github.com/containerd/nerdctl/blob/main/cmd/nerdctl/container/container_cp_acid_linux_test.go test: refactor container_cp_acid_linux_test.go to use Tigron #4737
• https://github.com/containerd/nerdctl/blob/main/cmd/nerdctl/container/container_cp_linux_test.go test: refactor container_cp_linux_test.go to use Tigron #5069
• https://github.com/containerd/nerdctl/blob/main/cmd/nerdctl/container/container_create_linux_test.go refactor: migrate container_create_linux_test.go to nerdtest.Setup #4900
• https://github.com/containerd/nerdctl/blob/main/cmd/nerdctl/container/container_exec_linux_test.go test: refactor container_exec_linux_test.go to use Tigron #4703
• https://github.com/containerd/nerdctl/blob/main/cmd/nerdctl/container/container_exec_test.go Refactor container_exec_test.go to use Tigron #4642
• https://github.com/containerd/nerdctl/blob/main/cmd/nerdctl/container/container_inspect_linux_test.go test: refactor container_inspect_linux_test.go to use Tigron #4748
• https://github.com/containerd/nerdctl/blob/main/cmd/nerdctl/container/container_inspect_windows_test.go test: refactor container_inspect_windows_test.go to use Tigron #4714
• https://github.com/containerd/nerdctl/blob/main/cmd/nerdctl/container/container_kill_linux_test.go test: refactor container_kill_linux_test.go to use Tigron #4693 Refactor container_kill_linux_test.go to use Tigron #5085
• https://github.com/containerd/nerdctl/blob/main/cmd/nerdctl/container/container_list_linux_test.go test: refactor container_list_linux_test.go to use Tigron #5058
• https://github.com/containerd/nerdctl/blob/main/cmd/nerdctl/container/container_list_test.go Refactor container_list_test.go to use Tigron #4641
• https://github.com/containerd/nerdctl/blob/main/cmd/nerdctl/container/container_list_windows_test.go Refactor container_list_windows_test.go to use Tigron #4643 refactor container_list_windows_test.go to use Tigron #4780
• https://github.com/containerd/nerdctl/blob/main/cmd/nerdctl/container/container_remove_windows_test.go test: refactor container_remove_windows_test.go to use Tigron #4734
• https://github.com/containerd/nerdctl/blob/main/cmd/nerdctl/container/container_rename_linux_test.go Refactor container_rename_linux_test.go to use Tigron #4687
• https://github.com/containerd/nerdctl/blob/main/cmd/nerdctl/container/container_rename_windows_test.go test: refactor container_rename_windows_test.go to use Tigron #4700
• https://github.com/containerd/nerdctl/blob/main/cmd/nerdctl/container/container_restart_linux_test.go test: refactor container_restart_linux_test.go to use Tigron #4742
• https://github.com/containerd/nerdctl/blob/main/cmd/nerdctl/container/container_run_cgroup_linux_test.go test: refactor container_run_cgroup_linux_test.go to use Tigron #5070
• https://github.com/containerd/nerdctl/blob/main/cmd/nerdctl/container/container_run_linux_test.go test: refactor container_run_linux_test.go to use Tigron #5071 test: convert TestRunCustomRootfs to Tigron framework #5086
• https://github.com/containerd/nerdctl/blob/main/cmd/nerdctl/container/container_run_log_driver_syslog_test.go refactor: migrate container_run_log_driver_syslog_test.go to nerdtest.Setup #4898
• https://github.com/containerd/nerdctl/blob/main/cmd/nerdctl/container/container_run_mount_linux_test.go test: refactor container_run_mount_linux_test.go to use Tigron #5045
• https://github.com/containerd/nerdctl/blob/main/cmd/nerdctl/container/container_run_mount_windows_test.go Refractor container_run_mount_windows_test.go to use Tigron #5074
• https://github.com/containerd/nerdctl/blob/main/cmd/nerdctl/container/container_run_network_base_test.go test: refactor container_run_network_base_test.go to use Tigron #5056
• https://github.com/containerd/nerdctl/blob/main/cmd/nerdctl/container/container_run_network_linux_test.go Refactor container_run_network_linux_test.go to use Tigron #5063
• https://github.com/containerd/nerdctl/blob/main/cmd/nerdctl/container/container_run_network_windows_test.go refactor: migrate container_run_network_windows_test.go to nerdtest.Setup #5014
• https://github.com/containerd/nerdctl/blob/main/cmd/nerdctl/container/container_run_restart_linux_test.go test: refactor container_run_restart_linux_test.go to use Tigron #4916
• https://github.com/containerd/nerdctl/blob/main/cmd/nerdctl/container/container_run_runtime_linux_test.go test: refactor container_run_runtime_linux_test.go to use Tigron #4698
• https://github.com/containerd/nerdctl/blob/main/cmd/nerdctl/container/container_run_security_linux_test.go test: refactor container_run_security_linux_test.go to use Tigron #4865
• https://github.com/containerd/nerdctl/blob/main/cmd/nerdctl/container/container_run_systemd_linux_test.go test: refactor container_run_systemd_linux_test.go to use Tigron #4708
• https://github.com/containerd/nerdctl/blob/main/cmd/nerdctl/container/container_run_test.go test: refactor container_run_test.go to use Tigron #4964
• https://github.com/containerd/nerdctl/blob/main/cmd/nerdctl/container/container_run_user_linux_test.go test: refactor container_run_user_linux_test.go to use Tigron #4726
• https://github.com/containerd/nerdctl/blob/main/cmd/nerdctl/container/container_run_user_windows_test.go test: refactor container_run_user_windows_test.go to use Tigron #4719
• https://github.com/containerd/nerdctl/blob/main/cmd/nerdctl/container/container_run_windows_test.go test: refactor container_run_windows_test.go to use Tigron #4729
• https://github.com/containerd/nerdctl/blob/main/cmd/nerdctl/container/container_start_test.go Refactor/container start test tigron #4675
• https://github.com/containerd/nerdctl/blob/main/cmd/nerdctl/container/container_stop_linux_test.go test: refactor container_stop_linux.go to use Tigron #4863
• https://github.com/containerd/nerdctl/blob/main/cmd/nerdctl/container/container_update_linux_test.go test: refactor container_update_linux_test.go to use Tigron #4711
• https://github.com/containerd/nerdctl/blob/main/cmd/nerdctl/container/multi_platform_linux_test.go refactor: migrate multi_platform_linux_test.go to nerdtest.Setup #4897
• https://github.com/containerd/nerdctl/blob/main/cmd/nerdctl/login/login_linux_test.go refactor: migrate login_linux_test.go to nerdtest.Setup #4907

[Deepam02]

@AkihiroSuda can i work on this?

[AkihiroSuda]

@Deepam02 Yes, of course.

I assigned @Deepam02 , but more contributors are welcome.

[haytok]

FYI:

• https://github.com/containerd/nerdctl/tree/main/docs/testing
• https://github.com/containerd/nerdctl/blob/main/docs/testing/tools.md

[AkihiroSuda]

• Refactor container_list_test.go to use Tigron #4641

Used Gemini, with the following prompt

Work on https://github.com/containerd/nerdctl/issues/4613 for @cmd/nerdctl/container/container_list_test.go .

- Try to preserve the original test structure as much as possible.
- In Tigron, `t.Parallel()` does not need to be explicitly set. Refer to @docs/testing/tools.md for further information about Tigron.
- To run a test, use `go test -exec sudo -run <TESTNAME> <PACKAGE>`.