Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sqlcipher: add 4.4.3 and requires openssl/1.1.1k #5508

Merged
merged 2 commits into from
May 22, 2021
Merged

sqlcipher: add 4.4.3 and requires openssl/1.1.1k #5508

merged 2 commits into from
May 22, 2021

Conversation

shiena
Copy link
Contributor

@shiena shiena commented May 10, 2021

fixed #5056

Specify library name and version: sqlcipher/4.4.3

sqlcipher 4.4.2 and below and openssl 1.1.1j and below are vulnerable.

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@CLAassistant
Copy link

CLAassistant commented May 10, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@conan-center-bot

This comment has been minimized.

Sign in to view
@shiena shiena mentioned this pull request May 10, 2021
Closed
This was referenced May 11, 2021
Open
Closed
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot
Copy link
Collaborator

All green in build 3 (662c4a1fe84a5439c2583d6da4988473bcc378fa):

  • sqlcipher/4.3.0@:
    All packages built successfully! (All logs)

  • sqlcipher/4.4.0@:
    All packages built successfully! (All logs)

  • sqlcipher/4.4.2@:
    All packages built successfully! (All logs)

  • sqlcipher/4.4.3@:
    All packages built successfully! (All logs)

@github-actions github-actions bot mentioned this pull request May 18, 2021
Open
mathbunnyru
mathbunnyru suggested changes May 20, 2021
View reviewed changes
Copy link
Contributor

@mathbunnyru mathbunnyru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's reuse patches from 4.4.2 if they don't actually change

@shiena
Copy link
Contributor Author

shiena commented May 20, 2021

@mathbunnyru
I used tools.patch and the fuzz=True option but it doesn't patch correctly. Probably there is a problem with conan-io/python-patch-ng#19 .

mathbunnyru
mathbunnyru approved these changes May 20, 2021
View reviewed changes
Copy link
Contributor

@mathbunnyru mathbunnyru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, if old patches do not work, then I'm ok with the new ones for the new version.

@conan-center-bot conan-center-bot merged commit 3e2fc70 into conan-io:master May 22, 2021
@shiena shiena deleted the feature/sqlcipher branch May 22, 2021 14:35
madebr pushed a commit to madebr/conan-center-index that referenced this pull request Jun 21, 2021
@shiena @madebr
(conan-io#5508) sqlcipher: add 4.4.3 and requires openssl/1.1.1k
670dc8c 
* sqlcipher: add 4.4.3 and requires openssl/1.1.1k

* Remove fPIC when use shared
@shiena shiena mentioned this pull request Dec 17, 2021
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prince-chrismc prince-chrismc prince-chrismc approved these changes

@mathbunnyru mathbunnyru mathbunnyru approved these changes

@SSE4 SSE4 SSE4 approved these changes

@lasote lasote Awaiting requested review from lasote

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[request] sqlcipher/4.4.3
6 participants
@shiena @CLAassistant @conan-center-bot @SSE4 @mathbunnyru @prince-chrismc