Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sqlcipher: add 4.5.0 and requires openssl/1.1.1m #8429

Merged
merged 8 commits into from
Dec 21, 2021
Merged

sqlcipher: add 4.5.0 and requires openssl/1.1.1m #8429

merged 8 commits into from
Dec 21, 2021
+220 −1

Conversation

shiena
Copy link
Contributor

@shiena shiena commented Dec 14, 2021

Specify library name and version: sqlcipher/4.5.0

SQLCipher 4.5.0 Release
https://www.zetetic.net/blog/2021/10/28/sqlcipher-4.5.0-release/

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@ghost ghost mentioned this pull request Dec 14, 2021
Closed
@ghost
Copy link

ghost commented Dec 14, 2021

I detected other pull requests that are modifying sqlcipher/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@prince-chrismc prince-chrismc mentioned this pull request Dec 14, 2021
Open
This was referenced Dec 14, 2021
Open
Closed
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@shiena shiena changed the title sqlcipher: add 4.5.0 and requires openssl/1.1.1l sqlcipher: add 4.5.0 and requires openssl/1.1.1m Dec 16, 2021
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot
Copy link
Collaborator

All green in build 6 (2a453c6ff4d99dae27bfa2f78644bed84971a5c7):

  • sqlcipher/4.5.0@:
    All packages built successfully! (All logs)

  • sqlcipher/4.4.0@:
    All packages built successfully! (All logs)

  • sqlcipher/4.4.2@:
    All packages built successfully! (All logs)

  • sqlcipher/4.3.0@:
    All packages built successfully! (All logs)

  • sqlcipher/4.4.3@:
    All packages built successfully! (All logs)

@shiena
Copy link
Contributor Author

shiena commented Dec 17, 2021

I have completed the fix and would appreciate a review.
The patch is a new addition because the fuzzy option doesn't work.
Please see #5508 (comment)

@SSE4 SSE4 requested a review from uilianries December 18, 2021 06:27
uilianries
uilianries approved these changes Dec 20, 2021
View reviewed changes
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@conan-center-bot conan-center-bot merged commit 2941b4f into conan-io:master Dec 21, 2021
@shiena shiena deleted the feature/sqlcipher branch December 21, 2021 19:59
miklelappo pushed a commit to miklelappo/conan-center-index that referenced this pull request Feb 9, 2022
@shiena @miklelappo
(conan-io#8429) sqlcipher: add 4.5.0 and requires openssl/1.1.1m
18aa97c 
* sqlcipher: add 4.5.0 and requires openssl/1.1.1l

* fix Makefile.msc-v4.5.0.patch

* sqlcipher: linking to the math library when using unix

* sqlcipher: requires openssl/1.1.1m

* Revert "sqlcipher: linking to the math library when using unix"

This reverts commit c63eba1.

* sqlcipher: fix linking

* Revert "sqlcipher: fix linking"

This reverts commit d68ecc0.

* sqlcipher: Link math when using 4.5.0 or higher
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prince-chrismc prince-chrismc prince-chrismc approved these changes

@uilianries uilianries uilianries approved these changes

@madebr madebr madebr approved these changes

@SSE4 SSE4 Awaiting requested review from SSE4

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@shiena @conan-center-bot @madebr @uilianries @prince-chrismc