Skip to content

[test] update tags #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 27, 2025
Merged

[test] update tags #146

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a058da
[test] update tags
Vipul-Cariappa May 22, 2025
f9c817f
fix test case & update test tags
Vipul-Cariappa May 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions test/test_cpp11features.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ class C(TestSmartPtr):
gc.collect()
assert TestSmartPtr.s_counter == 0

@mark.xfail
@mark.xfail(run=False, reason="Crashes on Valgrind")
def test04_shared_ptr_passing(self):
"""Ability to pass shared_ptr<Derived> through shared_ptr<Base>"""

Expand Down Expand Up @@ -143,7 +143,6 @@ def test04_shared_ptr_passing(self):
gc.collect()
assert TestSmartPtr.s_counter == 0

@mark.xfail
def test05_unique_ptr_passing(self):
"""Ability to pass unique_ptr<Derived> through unique_ptr<Base>"""

Expand Down Expand Up @@ -357,7 +356,6 @@ def test10_optional(self):
c = cppyy.gbl.std.nullopt
assert cppyy.gbl.callopt(c)

@mark.xfail
def test11_chrono(self):
"""Use of chrono and overloaded operator+"""

Expand Down
2 changes: 1 addition & 1 deletion test/test_crossinheritance.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,7 +341,7 @@ def call(self):
gc.collect()
assert CB.s_count == 0 + start_count

@mark.xfail(run=IS_CLANG_REPL, reason="Crashes otherwise")
@mark.xfail(run=False, condition=IS_CLING, reason="Crashes on Cling")
def test11_python_in_make_shared(self):
"""Usage of Python derived objects with std::make_shared"""

Expand Down
1 change: 0 additions & 1 deletion test/test_datatypes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2011,7 +2011,6 @@ class Atom {
assert b.name == "aap"
assert b.buf_type == ns.SHAPE

@mark.xfail
def test40_more_aggregates(self):
"""More aggregate testings (used to fail/report errors)"""

Expand Down
6 changes: 3 additions & 3 deletions test/test_pythonization.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ def test03_type_pinning(self):
assert type(result) == cppyy.gbl.pyzables.MyDerived


@mark.xfail
@mark.xfail(condition=IS_CLING, reason="Fails on Cling")
def test04_transparency(self):
"""Transparent use of smart pointers"""

Expand All @@ -141,7 +141,7 @@ def test04_transparency(self):
assert mine.__smartptr__().get().m_check == 0xcdcdcdcd
assert mine.say_hi() == "Hi!"

@mark.xfail
@mark.xfail(condition=IS_CLING, reason="Fails on Cling")
def test05_converters(self):
"""Smart pointer argument passing"""

Expand All @@ -167,7 +167,7 @@ def test05_converters(self):
# cppyy.gbl.mine = mine
pz.renew_mine()

@mark.xfail
@mark.xfail(condition=IS_CLING, reason="Fails on Cling")
def test06_executors(self):
"""Smart pointer return types"""

Expand Down
7 changes: 3 additions & 4 deletions test/test_stltypes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -531,7 +531,7 @@ def test12_vector_lifeline(self):
for val in l:
assert hasattr(val, '__lifeline')

@mark.xfail
@mark.xfail(condition=IS_MAC and IS_CLING, reason="Fails on OSX-Cling")
def test13_vector_smartptr_iteration(self):
"""Iteration over smart pointers"""

Expand Down Expand Up @@ -565,7 +565,7 @@ def test13_vector_smartptr_iteration(self):
i += 1
assert i == len(result)

@mark.xfail(run=not(IS_MAC and IS_CLING), condition=(IS_MAC and IS_CLING) or IS_MAC_X86, reason="Fails on OSX-Cling and OSX-X86 with clang-repl")
@mark.xfail(run=not(IS_MAC and IS_CLING), condition=(IS_MAC and IS_CLING), reason="Fails on OSX-Cling")
def test14_vector_of_vector_of_(self):
"""Nested vectors"""

Expand Down Expand Up @@ -1452,7 +1452,6 @@ def test03_stllike_preinc(self):
assert next(it).value == 1
assert next(it).value == 2

@mark.xfail
def test04_stllike_confusing_name(self):
"""Having "iterator" in the container name used to fail"""

Expand Down Expand Up @@ -1599,7 +1598,7 @@ def setup_class(cls):
import cppyy
cls.stltypes = cppyy.load_reflection_info(cls.test_dct)

@mark.xfail
@mark.xfail(condition=IS_MAC, reason="Fails on OSX")
def test01_string_through_string_view(self):
"""Usage of std::string_view as formal argument"""

Expand Down
3 changes: 1 addition & 2 deletions test/test_streams.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@ def test03_consistent_naming_if_char_traits(self):
cppyy.gbl.stringstream_base.pass_through_base(s)
assert s.str() == "TEST STRING"

@mark.xfail
def test04_naming_of_ostringstream(self):
"""Naming consistency of ostringstream"""

Expand All @@ -58,7 +57,7 @@ def test04_naming_of_ostringstream(self):
# Check if the object created is equal in all three cases
cl0 = cppyy.gbl.std.ostringstream
cl1 = cppyy.gbl.std.basic_ostringstream['char']
cl1 = cppyy.gbl.std.basic_ostringstream['char', cppyy.gbl.std.char_traits['char'] , cppyy.gbl.std.allocator['char']]
cl2 = cppyy.gbl.std.basic_ostringstream['char', cppyy.gbl.std.char_traits['char'] , cppyy.gbl.std.allocator['char']]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this has changed to cl2?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise it is a NameError in line 63-64.
There was a typo previously.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that an issue upstream?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upstream does it slightly differently. But it is cl2, https://github.com/wlav/cppyy/blob/48468034cae4f06a1d33c1c3f086c38a6e2e7c3a/test/test_streams.py#L71.


assert cl0 == cl1
assert cl1 == cl2
Expand Down
Loading