[test] update tags #146
Merged
[test] update tags #146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vgvassilev
reviewed
May 23, 2025
| @@ -58,7 +57,7 @@ def test04_naming_of_ostringstream(self): | |||
| # Check if the object created is equal in all three cases | |||
| cl0 = cppyy.gbl.std.ostringstream | |||
| cl1 = cppyy.gbl.std.basic_ostringstream['char'] | |||
| cl1 = cppyy.gbl.std.basic_ostringstream['char', cppyy.gbl.std.char_traits['char'] , cppyy.gbl.std.allocator['char']] | |||
| cl2 = cppyy.gbl.std.basic_ostringstream['char', cppyy.gbl.std.char_traits['char'] , cppyy.gbl.std.allocator['char']] | |||
There was a problem hiding this comment.
Otherwise it is a NameError in line 63-64.
There was a typo previously.
There was a problem hiding this comment.
Upstream does it slightly differently. But it is cl2, https://github.com/wlav/cppyy/blob/48468034cae4f06a1d33c1c3f086c38a6e2e7c3a/test/test_streams.py#L71.
vgvassilev
approved these changes
May 23, 2025
`test01_string_through_string_view` by compiler-research/CPyCppyy#91
|
I am merging this PR. As the failures are in emscripten, and cppyy does not support it. |
Vipul-Cariappa
merged commit afa173f
into
compiler-research:master
83 of 90 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed by compiler-research/cppyy-backend#139
Now that compiler-research/CppInterOp#580 is merged. I guess we should merge #145 before this PR.