tools/replay: rewrite in Python#36956
Closed
adeebshihadeh wants to merge 5 commits intomasterfrom
Closed
Conversation
adeebshihadeh
force-pushed
the
adeebshihadeh/replay-python-rewrite
branch
from
7ddb5bf to
41c4c0a
Compare
adeebshihadeh
force-pushed
the
adeebshihadeh/replay-python-rewrite
branch
from
cc96a05 to
45c8849
Compare
…bshihadeh/replay-python-rewrite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
kinda works but it's slower and stutters
we need to add a
--benchmarkto all our tools to surface this betterseparate issues hit while working on this