tici/ui: fix memory leak in WiFi list #36801
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deanlee
force-pushed
the
ui-wifi-remove-stale-wifi-network
branch
from
ad3a5d6 to
3b2598b
Compare
Contributor
raylib UI PreviewAll Screenshots
|
Contributor
|
is this only an issue for tici? |
Contributor
Author
|
Mici has memory leaks as well, but the leak observed in mici/_on_network_updated() comes from circular references — not the same root cause as on Tici. On Mici: openpilot/selfdrive/ui/mici/layouts/settings/network/wifi_ui.py Lines 395 to 396 in f78bacf However, this only removes the button objects from the list. |
deanlee
changed the title
deanlee
changed the title
deanlee
force-pushed
the
ui-wifi-remove-stale-wifi-network
branch
from
3b2598b to
0d9260c
Compare
Contributor
mici raylib UI Preview✅ Videos are identical! View Diff Report |
deanlee
force-pushed
the
ui-wifi-remove-stale-wifi-network
branch
from
0d9260c to
d31e85c
Compare
Contributor
|
Are these not applicable anymore? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates Tici
WifiManagerUI._on_network_updatedto delete button entries for SSIDs that no longer appear in the latest scan. This prevents stale UI items from lingering and also fixes a memory leak caused by unused button objects never being released.