Skip to content

Fix tici DM dialog memory leak #36790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sshane merged 6 commits into from
Dec 17, 2025
+8 −4
Merged

Fix tici DM dialog memory leak #36790

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e01dfec
not finished
sshane Dec 5, 2025
78032a0
Merge remote-tracking branch 'upstream/master' into fix-tici-memory-leak
sshane Dec 17, 2025
fc5042d
no
sshane Dec 17, 2025
df26719
debug
sshane Dec 17, 2025
cbcf307
clean up
sshane Dec 17, 2025
094c376
clean up
sshane Dec 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions selfdrive/ui/onroad/driver_camera_dialog.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,16 +14,20 @@ def __init__(self):
super().__init__("camerad", VisionStreamType.VISION_STREAM_DRIVER)
self.driver_state_renderer = DriverStateRenderer()
# TODO: this can grow unbounded, should be given some thought
device.add_interactive_timeout_callback(self.stop_dmonitoringmodeld)
device.add_interactive_timeout_callback(lambda: gui_app.set_modal_overlay(None))
ui_state.params.put_bool("IsDriverViewEnabled", True)

def stop_dmonitoringmodeld(self):
def hide_event(self):
super().hide_event()
ui_state.params.put_bool("IsDriverViewEnabled", False)
gui_app.set_modal_overlay(None)
self.close()

def _handle_mouse_release(self, _):
super()._handle_mouse_release(_)
self.stop_dmonitoringmodeld()
gui_app.set_modal_overlay(None)

def __del__(self):
self.close()

def _render(self, rect):
super()._render(rect)
Expand Down
Loading