Skip to content

Conversation

@greatgitsby
Copy link
Contributor

@greatgitsby greatgitsby commented Nov 19, 2025

show_event must fire before render. very important for NavWidget as it does setup on the show_event hook

before (note text flash before animation)

Screen.Recording.2025-11-21.at.8.57.22.PM.mov

after

Screen.Recording.2025-11-21.at.8.56.34.PM.mov

@github-actions github-actions bot added the ui label Nov 19, 2025
@greatgitsby greatgitsby marked this pull request as ready for review November 19, 2025 06:32
@github-actions
Copy link
Contributor

github-actions bot commented Nov 19, 2025

raylib UI Preview

All Screenshots

@greatgitsby greatgitsby changed the title fix: modal show ui: fix modal show Nov 19, 2025
@greatgitsby greatgitsby marked this pull request as draft November 24, 2025 19:01
@greatgitsby
Copy link
Contributor Author

greatgitsby commented Nov 24, 2025

not worth trying to fix right now, there are bugs with the ordering of when show/hide/render is called with modals that make this very tricky.

putting effort into stack manager instead, should fix all the weirdness

this bug is separate and is value-add for the time being

@greatgitsby greatgitsby reopened this Nov 26, 2025
@greatgitsby greatgitsby marked this pull request as ready for review November 26, 2025 16:58
@greatgitsby greatgitsby changed the title ui: fix modal show ui: fix modal show event firing after render Nov 26, 2025
@sshane
Copy link
Contributor

sshane commented Nov 27, 2025

not worth trying to fix right now, there are bugs with the ordering of when show/hide/render is called with modals that make this very tricky.

but were the bugs?

@greatgitsby
Copy link
Contributor Author

but were the bugs?

🔜

@sshane
Copy link
Contributor

sshane commented Dec 2, 2025

*what

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants