Skip to content

Conversation

@deanlee
Copy link
Contributor

@deanlee deanlee commented Oct 23, 2025

Scissor mode is not required for border drawing and introduces unnecessary overhead.

@sshane : I haven’t found any case where scissor mode or double draw_rectangle_rounded_lines_ex calls are necessary.
Is there any specific reason we need to keep scissor mode for this case?

@github-actions github-actions bot added the ui label Oct 23, 2025
@github-actions
Copy link
Contributor

raylib UI Preview

All Screenshots

@sshane
Copy link
Contributor

sshane commented Oct 23, 2025

There's a few pixels of camera view around the edges without the black. And then the scissor prevents overlap with sidebar

@deanlee
Copy link
Contributor Author

deanlee commented Oct 23, 2025

ah got it — makes sense. It should be safe to remove the scissor now, since we already moved draw_border to run after rendering the camera view in PR #36348. there’s no visible camera view around the edges anymore, and the sidebar won’t overlap since the outer black border is now drawn using draw_rectangle_lines_ex. here’s the comparison with master:

Master This Pr
Screenshot 2025-10-23 20:30:57 Screenshot 2025-10-23 20:29:41

@deanlee deanlee marked this pull request as ready for review October 23, 2025 12:39
@sshane sshane merged commit ad903ae into commaai:master Oct 25, 2025
11 checks passed
@deanlee deanlee deleted the ui-simplify-draw-border branch October 25, 2025 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants