Skip to content

Conversation

Quantizr
Copy link
Contributor

@Quantizr Quantizr commented Jun 23, 2025

Stores microphone audio in rlogs with a toggle. There is a recording indicator when the toggle is on, clicking the indicator opens the toggle.

There is also a script tools/scripts/extract_audio.py which allows you to extract the raw audio as a wav.

Renamed microphone service to soundPressure since it only logs soundsPressure.
New rawAudioData service to carry the raw audio data is saved in rlogs with the toggle.

@adeebshihadeh adeebshihadeh added this to the 0.9.10 milestone Jun 25, 2025
@Quantizr
Copy link
Contributor Author

mic icon when Record Microphone Audio toggle is turned on
image

clicking icon will take you to toggles page, needs #35604 to scroll down to the toggle

Copy link
Contributor

@adeebshihadeh adeebshihadeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this turned out bigger than I thought it would due to the qcam thing. Let's split this up one more time into everything except qcam part and qcam part.

After we get this merged, I also want to write a good test (#35605) before this feature goes to release.

@Quantizr
Copy link
Contributor Author

original body recording icon
image
some opacity
image
match dmon background/opacity
image
smaller orange mic
image

I have weird design preferences so I'm not sure I should be the one choosing which option

also, since not too many people will enable this, the icon should just disappear when not enabled instead of being greyed out like in the body recording icon right?

@adeebshihadeh
Copy link
Contributor

Let's do the one with some opacity. Also yeah, no icon if it's disabled.

@Quantizr
Copy link
Contributor Author

image

Copy link
Contributor

@adeebshihadeh adeebshihadeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the capnp backwards compatibility and CI failures, LGTM

@adeebshihadeh adeebshihadeh merged commit dcd56ae into master Jun 30, 2025
16 of 18 checks passed
@adeebshihadeh adeebshihadeh deleted the store-mic-audio branch June 30, 2025 20:42
@sshane
Copy link
Contributor

sshane commented Jun 30, 2025

mic indicator looks nice!

programanichiro added a commit to programanichiro/openpilot that referenced this pull request Jul 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants