-
Notifications
You must be signed in to change notification settings - Fork 10.1k
store mic audio with toggle #35595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
store mic audio with toggle #35595
Conversation
mic icon when Record Microphone Audio toggle is turned on clicking icon will take you to toggles page, needs #35604 to scroll down to the toggle |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this turned out bigger than I thought it would due to the qcam thing. Let's split this up one more time into everything except qcam part and qcam part.
After we get this merged, I also want to write a good test (#35605) before this feature goes to release.
Let's do the one with some opacity. Also yeah, no icon if it's disabled. |
This reverts commit 7baa1f6.
…tead of rlog" This reverts commit 7a3a75b.
Co-authored-by: Adeeb Shihadeh <[email protected]>
a9e3a29
to
ad6f946
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from the capnp backwards compatibility and CI failures, LGTM
mic indicator looks nice! |
This reverts commit dcd56ae.
Stores microphone audio in rlogs with a toggle. There is a recording indicator when the toggle is on, clicking the indicator opens the toggle.
There is also a script
tools/scripts/extract_audio.py
which allows you to extract the raw audio as a wav.Renamed
microphone
service tosoundPressure
since it only logs soundsPressure.New
rawAudioData
service to carry the raw audio data is saved in rlogs with the toggle.