Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HKG: Car Port for Hyundai Palisade and Kia Telluride 2023-24 (non-HDA2) #27478

Closed
wants to merge 101 commits into from

Conversation

sunnyhaibin
Copy link
Contributor

@sunnyhaibin sunnyhaibin commented Mar 2, 2023

Checklist

  • added entry to CarInfo in selfdrive/car/*/values.py and ran selfdrive/car/docs.py to generate new docs
  • test route added to routes.py
  • route with stock system:
    • Hyundai Palisade 2023: f2cf0de0119d2a16|2023-03-02--09-39-50
    • Kia Telluride 2023:
  • route with openpilot:
    • Hyundai Palisade 2023 (non-HDA2): f2cf0de0119d2a16|2023-03-03--21-13-05
    • Kia Telluride 2023 (non-HDA2):
  • harness type:
    • Hyundai Palisade 2023:
    • Kia Telluride 2023:
  • architecture: CAN-FD

Link to all physical parts during installation

Software URL

Requires

Resolves

Related

Thanks to community Hyundai Palisade 2023 owner SKILLED#7567 (Discord).

@sunnyhaibin sunnyhaibin changed the title HKG: Car Port for Hyundai Palisade 2023 and Kia Telluride 2023 (non-HDA2) HKG: Car Port for Hyundai Palisade and Kia Telluride 2023-24 (non-HDA2) Sep 24, 2023
…-2023-port-2

# Conflicts:
#	RELEASES.md
#	docs/CARS.md
#	opendbc
#	panda
#	selfdrive/car/hyundai/carstate.py
#	selfdrive/car/hyundai/interface.py
#	selfdrive/car/hyundai/values.py
#	selfdrive/car/torque_data/override.yaml
Copy link
Contributor

This PR has had no activity for 30 days. It will be automatically closed in 7 days if there is no activity.

Copy link
Contributor

github-actions bot commented Feb 8, 2024

It looks like you didn't use one of the Pull Request templates. Please check the contributing docs. Also make sure that you didn't modify any of the checkboxes or headings within the template.

Copy link
Contributor

github-actions bot commented Jun 17, 2024

Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:

  • Convert your PR to a draft unless it's ready to review
  • Read the contributing docs
  • Before marking as "ready for review", ensure:
    • the goal is clearly stated in the description
    • all the tests are passing
    • the change is something we merge
    • include a route or your device' dongle ID if relevant

@sshane
Copy link
Contributor

sshane commented Aug 20, 2024

We've moved the car interfacing code to our opendbc repository, which is now the new home for car ports and fingerprints. Please re-open your pull request against opendbc at your convenience by using this command below. This will transform all changes under selfdrive/car/ to opendbc_repo/opendbc/car/. Make sure you have initialized submodules beforehand and have checked out the latest opendbc commit.

PR_NUMBER=33045
curl -L https://github.com/commaai/openpilot/pull/$PR_NUMBER.patch | sed -e 's/selfdrive\/car/opendbc_repo\/opendbc\/car/g' | git apply -v --reject

Simply replace the PR number with your own. Once done, add the files, fix any conflicts, and open a new PR. Alternatively, you may start a new PR from scratch if that is easier for you.

@sshane sshane closed this Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants