HKG: Car Port for Hyundai Palisade 2023 and Kia Telluride 2023 #784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
sunnyhaibin
force-pushed
the
palisade-2023-port-1
branch
from
34d99bd
to
76a66f2
Compare
sunnyhaibin
force-pushed
the
palisade-2023-port-1
branch
from
777f847
to
76a66f2
Compare
adeebshihadeh
requested changes
Aug 25, 2023
sshane
reviewed
Aug 25, 2023
hyundai_palisade_2023.dbc
Outdated
Comment on lines
64
to
79
| BO_ 80 LKAS: 16 XXX | ||
| SG_ CHECKSUM : 0|16@1+ (1,0) [0|0] "" XXX | ||
| SG_ COUNTER : 16|8@1+ (1,0) [0|0] "" XXX | ||
| SG_ FCA_SYSWARN : 40|1@0+ (1,0) [0|0] "" XXX | ||
| SG_ LFA_BUTTON : 56|1@1+ (1,0) [0|0] "" XXX | ||
| SG_ LKA_ASSIST : 62|1@1+ (1,0) [0|0] "" XXX | ||
| SG_ LKA_ICON : 38|2@1+ (1,0) [0|0] "" XXX | ||
| SG_ LKA_MODE : 24|3@1+ (1,0) [0|0] "" XXX | ||
| SG_ LKA_WARNING : 32|1@1+ (1,0) [0|0] "" XXX | ||
| SG_ NEW_SIGNAL_1 : 27|2@1+ (1,0) [0|0] "" XXX | ||
| SG_ NEW_SIGNAL_2 : 70|2@0+ (1,0) [0|0] "" XXX | ||
| SG_ NEW_SIGNAL_3 : 111|8@0+ (1,0) [0|0] "" XXX | ||
| SG_ SET_ME_1 : 80|1@0+ (1,0) [0|0] "" XXX | ||
| SG_ STEER_MODE : 65|3@1+ (1,0) [0|0] "" XXX | ||
| SG_ STEER_REQ : 52|1@1+ (1,0) [0|0] "" XXX | ||
| SG_ TORQUE_REQUEST : 41|11@1+ (1,-1024) [0|0] "" XXX |
There was a problem hiding this comment.
This looks identical to LKAS in hyundai_canfd, let's make a base CAN FD DBC and put this in there.
hyundai_palisade_2023.dbc
Outdated
Comment on lines
38
to
62
| BO_ 67 DATC13: 8 XXX | ||
| SG_ CF_Datc_AcDisp : 22|2@1+ (1,0) [0|0] "" XXX | ||
| SG_ CF_Datc_AqsDisp : 20|2@1+ (1,0) [0|0] "" XXX | ||
| SG_ CF_Datc_AutoDefogBlink : 16|2@1+ (1,0) [0|0] "" XXX | ||
| SG_ CF_Datc_AutoDisp : 12|2@1+ (1,0) [0|0] "" XXX | ||
| SG_ CF_Datc_ChgReqDisp : 8|2@1+ (1,0) [0|0] "" XXX | ||
| SG_ CF_Datc_ClmScanDisp : 18|2@1+ (1,0) [0|0] "" XXX | ||
| SG_ CF_Datc_DualDisp : 30|2@1+ (1,0) [0|0] "" XXX | ||
| SG_ CF_Datc_FrDefLed : 14|2@1+ (1,0) [0|0] "" XXX | ||
| SG_ CF_Datc_FrontBlwDisp : 60|4@1+ (1,0) [0|0] "" XXX | ||
| SG_ CF_Datc_IntakeDisp : 10|2@1+ (1,0) [0|0] "" XXX | ||
| SG_ CF_Datc_IonClean : 6|2@1+ (1,0) [0|0] "" XXX | ||
| SG_ CF_Datc_ModDisp : 2|4@1+ (1,0) [0|0] "" XXX | ||
| SG_ CF_Datc_OpSts : 25|3@1+ (1,0) [0|0] "" XXX | ||
| SG_ CF_Datc_PSModDisp : 56|4@1+ (1,0) [0|0] "" XXX | ||
| SG_ CF_Datc_PwrInf : 32|4@1+ (1,0) [0|0] "" XXX | ||
| SG_ CF_Datc_RearAutoDisp : 40|2@1+ (1,0) [0|0] "" XXX | ||
| SG_ CF_Datc_RearBlwDisp : 52|4@1+ (1,0) [0|0] "" XXX | ||
| SG_ CF_Datc_RearChgReqDisp : 46|2@1+ (1,0) [0|0] "" XXX | ||
| SG_ CF_Datc_RearClimateScnDisp : 44|2@1+ (1,0) [0|0] "" XXX | ||
| SG_ CF_Datc_RearManual : 38|2@1+ (1,0) [0|0] "" XXX | ||
| SG_ CF_Datc_RearModDisp : 48|4@1+ (1,0) [0|0] "" XXX | ||
| SG_ CF_Datc_RearOffDisp : 42|2@1+ (1,0) [0|0] "" XXX | ||
| SG_ CF_Datc_TempDispUnit : 0|2@1+ (1,0) [0|0] "" XXX | ||
| SG_ CF_Mtc_MaxAcDisp : 28|2@1+ (1,0) [0|0] "" XXX |
There was a problem hiding this comment.
Is this also a duplicate on the one in hyundai_kia_generic?
There was a problem hiding this comment.
@sshane The platform has this message, but I'm not sure how relevant the definitions are or the use cases that would benefit us. We can remove this for the time being, or also have this generated and shared with hyundai_kia_generic.dbc.
There was a problem hiding this comment.
If the definition looks wrong, let's keep it in hyundai_kia_generic
|
@sshane Is this what we want? Wanted to double-check before I sync with the latest. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisite of