Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyundai: Disable longitudinal for HDA2 without ADAS Driving ECU #1295

Merged
merged 10 commits into from
Feb 23, 2025
Merged

Hyundai: Disable longitudinal for HDA2 without ADAS Driving ECU #1295

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
e6df03c
HKG: Disable longitudinal for Genesis G80 2024 (2.5T, HDA2)
sunnyhaibin Sep 27, 2024
7733134
use `Ecu.adas` to check dynamically
sunnyhaibin Sep 27, 2024
e7c965e
make sure it also checks no radar disable
sunnyhaibin Sep 27, 2024
7e4e2a1
static analysis
sunnyhaibin Sep 27, 2024
02e6f32
sync
sunnyhaibin Sep 27, 2024
5d828b7
fix
sunnyhaibin Sep 27, 2024
957422e
Merge branch 'master' into g80-hda2-no-long
adeebshihadeh Nov 28, 2024
aea7703
Merge remote-tracking branch 'commaai/opendbc/master' into g80-hda2-n…
sunnyhaibin Feb 22, 2025
ba23baf
fix
adeebshihadeh Feb 23, 2025
cc84e79
Merge branch 'master' of github.com:commaai/opendbc into g80-hda2-no-…
adeebshihadeh Feb 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion opendbc/car/hyundai/interface.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,11 @@ def _get_params(ret: structs.CarParams, candidate, fingerprint, car_fw, experime
CAN = CanBus(None, fingerprint, lka_steering)

if ret.flags & HyundaiFlags.CANFD:
# Shared configuration for CAN-FD cars
ret.experimentalLongitudinalAvailable = candidate not in (CANFD_UNSUPPORTED_LONGITUDINAL_CAR | CANFD_RADAR_SCC_CAR)
if lka_steering and Ecu.adas not in [fw.ecu for fw in car_fw]:
# this needs to be figured out for cars without an ADAS ECU
ret.experimentalLongitudinalAvailable = False

ret.enableBsm = 0x1e5 in fingerprint[CAN.ECAN]

if 0x105 in fingerprint[CAN.ECAN]:
Expand Down