-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2021+ Rav4 Prime #1005
Draft
pd0wm
wants to merge
6
commits into
commaai:master
Choose a base branch
from
pd0wm:rav4-prime
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
2021+ Rav4 Prime #1005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sshane
reviewed
Jan 30, 2024
Comment on lines
17
to
22
BO_ 305 LTA_RELATED_2: 8 XXX | ||
SG_ COUNTER : 13|6@0+ (1,0) [0|63] "" XXX | ||
SG_ STEERING_ANGLE_RELATED : 23|16@0- (1,0) [0|65535] "" XXX | ||
SG_ AUTHENTICATOR : 35|28@0+ (1,0) [0|268435455] "" XXX | ||
SG_ RESET_FLAG : 37|2@0+ (1,0) [0|3] "" XXX | ||
SG_ MSG_CNT_LOWER : 39|2@0+ (1,0) [0|3] "" XXX |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
BO_ 305 LTA_RELATED_2: 8 XXX | |
SG_ COUNTER : 13|6@0+ (1,0) [0|63] "" XXX | |
SG_ STEERING_ANGLE_RELATED : 23|16@0- (1,0) [0|65535] "" XXX | |
SG_ AUTHENTICATOR : 35|28@0+ (1,0) [0|268435455] "" XXX | |
SG_ RESET_FLAG : 37|2@0+ (1,0) [0|3] "" XXX | |
SG_ MSG_CNT_LOWER : 39|2@0+ (1,0) [0|3] "" XXX | |
BO_ 305 LTA_RELATED_2: 8 XXX | |
SG_ STEER_REQUEST_1 : 0|1@0+ (1,0) [0|1] "" XXX | |
SG_ STEER_REQUEST_2 : 3|1@0+ (1,0) [0|1] "" XXX | |
SG_ COUNTER : 13|6@0+ (1,0) [0|63] "" XXX | |
SG_ STEERING_ANGLE_CMD : 23|16@0- (0.0573,0) [0|65535] "" XXX | |
SG_ AUTHENTICATOR : 35|28@0+ (1,0) [0|268435455] "" XXX | |
SG_ RESET_FLAG : 37|2@0+ (1,0) [0|3] "" XXX | |
SG_ MSG_CNT_LOWER : 39|2@0+ (1,0) [0|3] "" XXX |
Think they moved the angle request to this message, you can see the angle snap to the current angle when LKAS_HUD reports no LKAS:
pd0wm
force-pushed
the
rav4-prime
branch
5 times, most recently
from
March 19, 2024 10:51
916726e
to
acbf1f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example Route:
20ba9ade056a8c7b|2021-02-08--21-57-35
BRAKE_MODULE
,GEAR_PACKET
,PCM_CRUISE
.KINEMATICS
is also missing, but not used by openpilot.STEERING_LKA
,LTA_RELATED
(related to LTA based on FW analysis, no LTA drive seen yet.STEERING_LTA
does not have SeOC),PRE_COLLISION
(TheSTATE
field is now occupied by the MAC. How does the new layout work?).PRE_COLLISION_2
.GEAR_PACKET_HYBRID.COUNTER
, it's not a counter and fails some checks in openpilot. Also see this corolla hybrid route075b133b6181e058|2024-01-26--10-39-08
.