Skip to content

fix: support for multibyte folder names when the app is served from a subfolder #9615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

michalsn
Copy link
Member

Description
This PR fixes a bug where folder names containing multibyte (non-ASCII) characters were not correctly resolved by SiteURIFactory::parseRequestURI() when the application was served from a subfolder.

The problem was spotted here: #9613 (comment)

Needs #9613

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@michalsn michalsn added the bug Verified issues on the current code behavior or pull requests that will fix them label Jun 27, 2025
@michalsn michalsn force-pushed the fix/multibyte-characters-in-folder-name branch from 9e157f0 to 3b5b6ff Compare June 30, 2025 05:26
@michalsn michalsn force-pushed the fix/multibyte-characters-in-folder-name branch from 3b5b6ff to 06f1944 Compare June 30, 2025 06:04
@michalsn michalsn merged commit 78f3842 into codeigniter4:develop Jun 30, 2025
50 checks passed
@michalsn
Copy link
Member Author

Thank you @samsonasik and @paulbalandan

@michalsn michalsn deleted the fix/multibyte-characters-in-folder-name branch June 30, 2025 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants