Skip to content

fix: correct path parsing in SiteURIFactory::parseRequestURI() #9613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

michalsn
Copy link
Member

Description
This PR fixes a bug where route path detection was failing when serving the app from a subfolder using Apache mod_rewrite (to "hide" public directory) while preserving index.php in URL.


So something like: https://localhost/ci/index.php/controller/method - when our real directory structure was like: ci/public/index.php. This caused the route path to return: index.php/controller/method instead of controller/method.

Closes #9607
Fixes #9602

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@michalsn michalsn added the bug Verified issues on the current code behavior or pull requests that will fix them label Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: codeigniter in a subdirectory + indexPage results in 404
2 participants