Updated channel and documentation to Rubocop v1.4.1 #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to support the 1.x versions of Rubocop, three additional dependencies also require upgrades: - rubocop-sequel, the update to which is already complete and released; - rubocop-i18n, the update to which is in-flight (see puppetlabs/rubocop-i18n#46) - rubocop-migrations, the update to which is in-flight (see redbooth/rubocop-migrations#3) The commit here will pass CI, but the in-flight PRs should be merged and released to RubyGems before merging this PR.
DanielWright
commented
Nov 24, 2020
Comment on lines
+10
to
+11
| gem "rubocop-i18n", require: false, | ||
| github: "mvz/rubocop-i18n", ref: "5e824a47a88732830a8b60e46697bbb0a2795c19" |
There was a problem hiding this comment.
Suggested change
| gem "rubocop-i18n", require: false, | |
| github: "mvz/rubocop-i18n", ref: "5e824a47a88732830a8b60e46697bbb0a2795c19" | |
| gem "rubocop-i18n", require: false |
This change should be applied when puppetlabs/rubocop-i18n#46 is merged and released.
There was a problem hiding this comment.
@DanielWright wouldn't this PR be merged faster, if you stick to @mvz s branch for now?
I suggest to move this change into another pull request.
Comment on lines
+12
to
+13
| gem "rubocop-migrations", require: false, | ||
| github: "DanielWright/rubocop-migrations", branch: "dw/nov24/rubocop-1.x-support" |
There was a problem hiding this comment.
Suggested change
| gem "rubocop-migrations", require: false, | |
| github: "DanielWright/rubocop-migrations", branch: "dw/nov24/rubocop-1.x-support" | |
| gem "rubocop-migrations", require: false |
This change should be applied when redbooth/rubocop-migrations#3 is merged and released.
Closed
|
@DanielWright the channel branch was causing some confusion to other customers, so we delete it for now. I think by doing so we closed this PR automatically. Please, feel free to re-open it (PR and branch) when you feel we are in a better place to ship this version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The versioning scheme change to
1.xwas kinda disruptive! A handful of dependencies were unable to resolve following the update. These have been patched, but in two cases the associated PRs have not yet been merged and released to RubyGems. Merging this should probably wait for that to happen.