Update rubocop to version '1.x' #33
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sidekiq-undertaker.gemspec
Outdated
| @@ -25,6 +25,8 @@ Gem::Specification.new do |spec| | |||
| "build_status_uri" => "https://travis-ci.org/ThomasKoppensteiner/sidekiq-undertaker" | |||
| } | |||
|
|
|||
| spec.required_ruby_version = ">= 2.4.0" | |||
There was a problem hiding this comment.
Related to rt_rubocop_defaults. Try to upgrade it there first.
ThomasKoppensteiner
force-pushed
the
rubocop_1_2
branch
from
0e41e59 to
84026e4
Compare
ThomasKoppensteiner
changed the title
.codeclimate.yml
Outdated
| @@ -8,6 +8,6 @@ plugins: | |||
| enabled: true | |||
| rubocop: | |||
| enabled: true | |||
| channel: rubocop-0-77 | |||
| channel: rubocop-1-2 | |||
There was a problem hiding this comment.
Needs codeclimate/codeclimate-rubocop#262 and puppetlabs/rubocop-i18n#46 to be merged and released
There was a problem hiding this comment.
Lets use 1.4, when codeclimate/codeclimate-rubocop#263 is released
sidekiq-undertaker.gemspec
Outdated
| spec.add_development_dependency "rt_rubocop_defaults", "~> 1.2" | ||
| spec.add_development_dependency "rubocop", "~> 0.77" | ||
| spec.add_development_dependency "rubocop-rspec", "~> 1.30" | ||
| spec.add_development_dependency "rt_rubocop_defaults", "~> 2.1" |
There was a problem hiding this comment.
Wait until runtastic/rt_rubocop_defaults#13 is merged and released
ThomasKoppensteiner
force-pushed
the
rubocop_1_2
branch
2 times, most recently
from
ac22784 to
f182ffd
Compare
ThomasKoppensteiner
force-pushed
the
rubocop_1_2
branch
from
f182ffd to
4329f70
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes related to
rubocopupgrade (#32).