Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fr] Enable link checking, and normalize links, add missing #3197

Merged
merged 2 commits into from
Jul 22, 2024

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Jun 13, 2024

  • Contributes to Enable link checking (paths) across languages #3190
  • Normalizes links, adding a trailing slash, as reported by the link checker
  • Adds a missing link to the containerization page -- so as to match the English base language version of the page
  • There are no other changes. Paragraphs were line-wrapped à la Prettier.

Copy link

netlify bot commented Jun 13, 2024

Deploy Preview for cncfglossary ready!

Name Link
🔨 Latest commit 6e177e8
🔍 Latest deploy log https://app.netlify.com/sites/cncfglossary/deploys/6681cceebec2a700083349d7
😎 Deploy Preview https://deploy-preview-3197--cncfglossary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@chalin chalin force-pushed the chalin-im-link-normalization-2024-06-13 branch 3 times, most recently from 51ce323 to 9eb1e48 Compare June 13, 2024 23:16
Copy link
Member

@nate-double-u nate-double-u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, with the caveat that I don't read French very well. Given that these are just link updates, I feel I can help review them.

The link updates are correct.

content/fr/container-orchestration.md Outdated Show resolved Hide resolved
@chalin chalin force-pushed the chalin-im-link-normalization-2024-06-13 branch from 9eb1e48 to 6e177e8 Compare June 30, 2024 21:23
@chalin chalin requested a review from seb-835 as a code owner June 30, 2024 21:23
@chalin chalin requested a review from sestegra June 30, 2024 21:26
Copy link
Collaborator

@sestegra sestegra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chalin Thank you for your support.
LGTM 🚀

Copy link
Collaborator

@seb-835 seb-835 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chalin
Copy link
Contributor Author

chalin commented Jul 12, 2024

@nate-double-u - what is the process here? How many approvals are required?

@Krast76
Copy link
Collaborator

Krast76 commented Jul 21, 2024

@nate-double-u - what is the process here? How many approvals are required?

We can't merge into main. If you change the target branch from main to dev-fr we'll have the rights to do so.

Copy link
Collaborator

@seokho-son seokho-son left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. and Let me merge this PR on behalf of French approvals.

@seokho-son seokho-son merged commit f1cc87d into cncf:main Jul 22, 2024
7 checks passed
@chalin chalin deleted the chalin-im-link-normalization-2024-06-13 branch July 27, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/fr for French
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants