No more duplicate meta domain annotation #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ate_meta_domain_annotation
…ndancy. Added initialization via variant; revised some error texts
…bs for the new static methods
…air_representation
…t_aa and added uniquestrrep
…ild it. Added method stub for retrieving sngle positions
…evariant; simplefied the task for prebuilding
…ed get genomic position of change
…ted the toGnommADJson with proper fields
|
The positions that are not aligned to a meta-domain, but are in a domain cause crashes... needs be fixed first. Also we need a loading screen for the larger meta-domains |
|
@cbaakman kun je globaal over de code kijken hier en zo nodig comments geven? |
cbaakman
reviewed
Sep 6, 2018
There was a problem hiding this comment.
In https://github.com/cmbi/metadome/pull/25/files#diff-e0ea0ff2bfa2da617e771484cba76472R247, there's a method called "toCodonJson". However, it actually creates a dictionary. (not a json string)
So why not name it 'as_dict' or something like that?
Also, what about the method "toDict" in the same class. Can't you use that method instead?
cbaakman
requested changes
Sep 6, 2018
cbaakman
reviewed
Sep 6, 2018
cbaakman
reviewed
Sep 6, 2018
cbaakman
reviewed
Sep 6, 2018
This was referenced Sep 6, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed fix for #12 and #11