Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move toJson functions to presentation/api #27

Open
laurensvdwiel opened this issue Sep 6, 2018 · 0 comments
Open

Move toJson functions to presentation/api #27

laurensvdwiel opened this issue Sep 6, 2018 · 0 comments
Assignees
@laurensvdwiel
Labels
Could Low priority enhancement

Comments

@laurensvdwiel
Copy link
Member

These functions (toCodonJson(), toJson(), toGnommadJson() and toClinVarJson()) that exist in Codon and SingleNucleotideVariant as of #25 should be moved to the presentation layer for better code-maintainability.

The gene_region is impacted by this and requires a refactoring (see issue: ) so that it more efficiently makes use of Codon objects.
@laurensvdwiel laurensvdwiel self-assigned this Sep 6, 2018
@laurensvdwiel laurensvdwiel changed the title Improve code future maintainability: Move toJson functions to presentation/api Move toJson functions to presentation/api Sep 6, 2018
@laurensvdwiel laurensvdwiel mentioned this issue Sep 6, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@laurensvdwiel laurensvdwiel

Labels
Could Low priority enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@laurensvdwiel