chore: implment write insert logic #93
Conversation
mnorbury
force-pushed
the
chore/add-write-insert-logic
branch
from
b46b17e to
3051991
Compare
| try (ArrowStreamReader reader = | ||
| new ArrowStreamReader(byteString.newInput(), bufferAllocator)) { | ||
| VectorSchemaRoot vectorSchemaRoot = reader.getVectorSchemaRoot(); | ||
| reader.loadNextBatch(); |
There was a problem hiding this comment.
I think we would need to loop on loadNextBatch until it returns false, see https://arrow.apache.org/docs/java/reference/org/apache/arrow/vector/ipc/ArrowStreamReader.html#loadNextBatch--
Though maybe not an issue at the moment since we always send a single record batch?
There was a problem hiding this comment.
Currently the method signature implies only a single item Resource decodeResource(ByteString byteString), do you think I should generalise this to a list?
There was a problem hiding this comment.
Let's keep it as is for now and change it if we run into issues
| @@ -61,6 +59,9 @@ public UUIDVector(String name, BufferAllocator allocator, FixedSizeBinaryVector | |||
|
|
|||
| @Override | |||
| public Object getObject(int index) { | |||
| if (getUnderlyingVector().isSet(index) == 0) { | |||
| if (description != null) { | ||
| tableBuilder.description(description); | ||
| } | ||
| Table.builder() |
| @@ -105,6 +105,9 @@ public static Scalar<?> fromArrowType(ArrowType arrowType) { | |||
| case Duration -> { | |||
| return new Duration(); | |||
| } | |||
| case List -> { | |||
| return new JSON(); | |||
There was a problem hiding this comment.
For now we will map arrow types of List to the JSON extension type.
| try (ArrowStreamReader reader = | ||
| new ArrowStreamReader(byteString.newInput(), bufferAllocator)) { | ||
| VectorSchemaRoot vectorSchemaRoot = reader.getVectorSchemaRoot(); | ||
| reader.loadNextBatch(); |
There was a problem hiding this comment.
Currently the method signature implies only a single item Resource decodeResource(ByteString byteString), do you think I should generalise this to a list?
refs: #85