chore: adding supporting decode for write logic #89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnorbury
force-pushed
the
chore/add-write-migration-logic
branch
2 times, most recently
from
5fee296 to
e57f2ee
Compare
mnorbury
force-pushed
the
chore/add-write-migration-logic
branch
from
e57f2ee to
196867d
Compare
erezrokah
approved these changes
Aug 23, 2023
| String parent = metaData.get(CQ_TABLE_DEPENDS_ON); | ||
|
|
||
| TableBuilder tableBuilder = Table.builder().name(name).columns(columns); | ||
| if (title != null) { |
There was a problem hiding this comment.
[non blocking] I think we can skip these null checks and pass everything to builder. If the values are null it won't change anything on the resulted table, WDYT?
There was a problem hiding this comment.
Yeah, that makes sense. I'll modify as part of the next PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for the
MessageMigrateTablerequestsrefs: #85