Add preview metadata to buffered tail traces#6375
Open
Ankcorn wants to merge 1 commit intocloudflare:mainfrom
Open
Add preview metadata to buffered tail traces#6375Ankcorn wants to merge 1 commit intocloudflare:mainfrom
Ankcorn wants to merge 1 commit intocloudflare:mainfrom
Conversation
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
Ankcorn
commented
Mar 20, 2026
|
|
||
| TraceEventInfo::TraceItem::TraceItem(rpc::Trace::TraceEventInfo::TraceItem::Reader reader) | ||
| : scriptName(kj::str(reader.getScriptName())) {} | ||
| : scriptName(reader.hasScriptName() ? kj::Maybe<kj::String>(kj::str(reader.getScriptName())) |
Author
There was a problem hiding this comment.
Opencode drive by changed this because it thinks the old implementation has a bug...
IMO seems suss and I'm going to revert this line but hello @danlapid I just wanted to flag it to you incase opencode smarter than me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add preview metadata to buffered tail traces.
This exposes:
to classic/buffered tail workers.
Why Why
edgeworker needs to surface pipeline-level preview identity in classic tail worker
observability.
That requires workerd to support carrying preview metadata through the buffered trace path;
otherwise classic tail workers only receive traces without any preview context.
Changes
Notes
This only adds the workerd support layer. The corresponding edgeworker change is what populates
this field from pipeline preview metadata.