Fix C# module bindings codegen for namespaces with view dispatcher #3668
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rekhoff
changed the base branch from
master
to
joshua/fix/client-bindings-for-views
joshua-spacetime
force-pushed
the
joshua/fix/client-bindings-for-views
branch
from
89daaa1 to
57dd028
Compare
joshua-spacetime
force-pushed
the
joshua/fix/client-bindings-for-views
branch
from
57dd028 to
9a10dc1
Compare
rekhoff
approved these changes
Nov 19, 2025
Contributor
rekhoff
left a comment
rekhoff
left a comment
There was a problem hiding this comment.
No objections here, the change makes sense and works as intended
joshua-spacetime
force-pushed
the
joshua/fix/client-bindings-for-views
branch
3 times, most recently
from
65e12df to
456d746
Compare
Base automatically changed from
joshua/fix/client-bindings-for-views
to
master
November 19, 2025 21:16
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Closes: #3658
With the work on Views we ran into trouble with the Return Type and certain C# code layout where the types are defined inside the Module class. This fixes the bug in our current approach but needs consideration to possibly be changed entirely.
API and ABI breaking changes
N/A
Expected complexity level and risk
1 - Minor change
Testing