Fix C# module bindings codegen for namespaces with view dispatcher (#3668)

# Description of Changes

Closes: #3658 
With the work on Views we ran into trouble with the Return Type and
certain C# code layout where the types are defined inside the Module
class. This fixes the bug in our current approach but needs
consideration to possibly be changed entirely.

# API and ABI breaking changes

N/A

# Expected complexity level and risk

1 - Minor change

# Testing

- [x] Retested with the linked code with and without the namespace
- [x] Re-ran regression tests

---------

Co-authored-by: John Detter <[email protected]>
Co-authored-by: joshua-spacetime <[email protected]>
Co-authored-by: rekhoff <[email protected]>

Author: 4 people

crates/bindings-csharp/Codegen/Module.cs

@@ -997,10 +997,7 @@ public string GenerateViewDef(uint Index) =>
                 IsPublic: {{{IsPublic.ToString().ToLower()}}},
                 IsAnonymous: {{{IsAnonymous.ToString().ToLower()}}},
                 Params: [{{{MemberDeclaration.GenerateDefs(Parameters)}}}],
-                ReturnType: new {{{ReturnType.BSATNName.Replace(
-                "Module.",
-                "global::Module."
-            )}}}().GetAlgebraicType(registrar)
+                ReturnType: new {{{ReturnType.BSATNName}}}().GetAlgebraicType(registrar)
             );
             """;
 

modules/sdk-test-cs/Lib.cs

@@ -848,7 +848,12 @@ public static void insert_unique_u32(ReducerContext ctx, uint n, int data)
     }
 
     [SpacetimeDB.Reducer]
-    public static void insert_unique_u32_update_pk_u32(ReducerContext ctx, uint n, int d_unique, int d_pk)
+    public static void insert_unique_u32_update_pk_u32(
+        ReducerContext ctx,
+        uint n,
+        int d_unique,
+        int d_pk
+    )
     {
         ctx.Db.unique_u32.Insert(new UniqueU32 { n = n, data = d_unique });
         ctx.Db.pk_u32.n.Update(new PkU32 { n = n, data = d_pk });
@@ -1715,9 +1720,7 @@ public static void insert_caller_one_identity(ReducerContext ctx)
     [SpacetimeDB.Reducer]
     public static void insert_caller_vec_identity(ReducerContext ctx)
     {
-        ctx.Db.vec_identity.Insert(
-                                   new VecIdentity { i = new List<Identity> { ctx.Sender } }
-        );
+        ctx.Db.vec_identity.Insert(new VecIdentity { i = new List<Identity> { ctx.Sender } });
     }
 
     [SpacetimeDB.Reducer]
@@ -1735,7 +1738,9 @@ public static void insert_caller_pk_identity(ReducerContext ctx, int data)
     [SpacetimeDB.Reducer]
     public static void insert_caller_one_connection_id(ReducerContext ctx)
     {
-        ctx.Db.one_connection_id.Insert(new OneConnectionId { a = (ConnectionId)ctx.ConnectionId! });
+        ctx.Db.one_connection_id.Insert(
+            new OneConnectionId { a = (ConnectionId)ctx.ConnectionId! }
+        );
     }
 
     [SpacetimeDB.Reducer]
@@ -1753,14 +1758,16 @@ public static void insert_caller_vec_connection_id(ReducerContext ctx)
     public static void insert_caller_unique_connection_id(ReducerContext ctx, int data)
     {
         ctx.Db.unique_connection_id.Insert(
-                                     new UniqueConnectionId { a = (ConnectionId)ctx.ConnectionId!, data = data }
+            new UniqueConnectionId { a = (ConnectionId)ctx.ConnectionId!, data = data }
         );
     }
 
     [SpacetimeDB.Reducer]
     public static void insert_caller_pk_connection_id(ReducerContext ctx, int data)
     {
-        ctx.Db.pk_connection_id.Insert(new PkConnectionId { a = (ConnectionId)ctx.ConnectionId!, data = data });
+        ctx.Db.pk_connection_id.Insert(
+            new PkConnectionId { a = (ConnectionId)ctx.ConnectionId!, data = data }
+        );
     }
 
     [SpacetimeDB.Reducer]
@@ -1782,7 +1789,11 @@ public static void delete_from_btree_u32(ReducerContext ctx, List<BTreeU32> rows
     }
 
     [SpacetimeDB.Reducer]
-    public static void insert_into_pk_btree_u32(ReducerContext ctx, List<PkU32> pk_u32, List<BTreeU32> bt_u32)
+    public static void insert_into_pk_btree_u32(
+        ReducerContext ctx,
+        List<PkU32> pk_u32,
+        List<BTreeU32> bt_u32
+    )
     {
         foreach (var row in pk_u32)
         {
@@ -1950,7 +1961,6 @@ public static void insert_primitives_as_strings(ReducerContext ctx, EveryPrimiti
                             return value.ToString()!.ToLowerInvariant();
                         }
                         return value.ToString()!;
-
                     })
                     .ToList(),
             }
@@ -2032,7 +2042,9 @@ public partial struct BTreeU32
     }
 
     [SpacetimeDB.ClientVisibilityFilter]
-    public static readonly Filter USERS_FILTER = new Filter.Sql("SELECT * FROM users WHERE identity = :sender");
+    public static readonly Filter USERS_FILTER = new Filter.Sql(
+        "SELECT * FROM users WHERE identity = :sender"
+    );
 
     [SpacetimeDB.Table(Name = "users", Public = true)]
     public partial struct Users
@@ -2049,7 +2061,8 @@ public static void insert_user(ReducerContext ctx, string name, Identity identit
     }
 
     [SpacetimeDB.Table(Name = "indexed_simple_enum", Public = true)]
-    public partial struct IndexedSimpleEnum {
+    public partial struct IndexedSimpleEnum
+    {
         [SpacetimeDB.Index.BTree]
         public SimpleEnum n;
     }