Skip to content

feat(astro): Add <PricingTable /> component #5774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
May 6, 2025
Merged

feat(astro): Add <PricingTable /> component #5774

merged 20 commits into from
May 6, 2025
+39 −1

Conversation

octoper
Copy link
Member

@octoper octoper commented Apr 30, 2025 •
edited by LekoArts
Loading

Description

Add <PricingTable /> component to the Astro SDK.

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 30, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 33160e4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@clerk/astro Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Apr 30, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
clerk-js-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 6, 2025 0:35am

@octoper octoper changed the base branch from main to vaggelis/com-446-vue-sdk-support April 30, 2025 16:51
@octoper
Copy link
Member Author

octoper commented Apr 30, 2025

!snapshot

@clerk-cookie

This comment was marked as outdated.

Sign in to view
@octoper octoper force-pushed the vaggelis/com-680-astro-support branch from b483a9a to 69844fe Compare April 30, 2025 17:10
@octoper octoper changed the title feat(vue,nuxt): Add <__experimental_PricingTable> component feat(vue,nuxt): Add <experimental_PricingTable> component Apr 30, 2025
@octoper octoper changed the title feat(vue,nuxt): Add <experimental_PricingTable> component feat(astro): Add <experimental_PricingTable> component Apr 30, 2025
@octoper octoper force-pushed the vaggelis/com-680-astro-support branch from 69844fe to 7a30ec2 Compare May 2, 2025 05:55
@octoper octoper changed the title feat(astro): Add <experimental_PricingTable> component feat(astro): Introduce <experimental_PricingTable> component May 2, 2025
@octoper octoper self-assigned this May 2, 2025
@octoper octoper changed the base branch from vaggelis/com-446-vue-sdk-support to main May 2, 2025 06:01
@octoper octoper changed the base branch from main to vaggelis/com-446-vue-sdk-support May 2, 2025 06:02
@octoper octoper force-pushed the vaggelis/com-680-astro-support branch from 7a30ec2 to 3808d7d Compare May 2, 2025 06:06
Base automatically changed from vaggelis/com-446-vue-sdk-support to main May 2, 2025 06:12
@octoper octoper force-pushed the vaggelis/com-680-astro-support branch from e18e93e to 6278f21 Compare May 2, 2025 14:36
@octoper octoper marked this pull request as ready for review May 2, 2025 14:36
wobsoriano
wobsoriano approved these changes May 2, 2025
View reviewed changes
Copy link
Member

@wobsoriano wobsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good

@alexcarpenter alexcarpenter mentioned this pull request May 4, 2025
Merged
9 tasks
LekoArts
LekoArts previously requested changes May 5, 2025
View reviewed changes
@LekoArts LekoArts mentioned this pull request May 5, 2025
Open
2 tasks
@LekoArts LekoArts dismissed their stale review May 5, 2025 04:30

Non-blocking

LekoArts
LekoArts reviewed May 6, 2025
View reviewed changes
Copy link
Member

@LekoArts LekoArts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess with #5828 merged we need to rename the component

@LekoArts LekoArts changed the title feat(astro): Introduce <experimental_PricingTable> component feat(astro): Add <PricingTable /> component May 6, 2025
@wobsoriano
Copy link
Member

I guess with #5828 merged we need to rename the component

Changes looks good!

LekoArts
LekoArts approved these changes May 6, 2025
View reviewed changes
Copy link
Member

@LekoArts LekoArts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

obvqaa0lhn841

@LekoArts LekoArts merged commit 895a1a3 into main May 6, 2025
38 checks passed
@LekoArts LekoArts deleted the vaggelis/com-680-astro-support branch May 6, 2025 00:51
@clerk-cookie clerk-cookie mentioned this pull request May 6, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wobsoriano wobsoriano wobsoriano approved these changes

@LekoArts LekoArts LekoArts approved these changes

@tmilewski tmilewski Awaiting requested review from tmilewski

@anagstef anagstef Awaiting requested review from anagstef

@panteliselef panteliselef Awaiting requested review from panteliselef

Assignees

@octoper octoper

Labels
astro integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@octoper @clerk-cookie @wobsoriano @LekoArts