-
Notifications
You must be signed in to change notification settings - Fork 339
feat(clerk-js,types): Add __experiemental_checkoutContinueUrl option #5807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(clerk-js,types): Add __experiemental_checkoutContinueUrl option #5807
Conversation
🦋 Changeset detectedLatest commit: 7b2bc7a The changes in this PR will be included in the next version bump. This PR includes changesets to release 22 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
!snapshot |
Hey @alexcarpenter - the snapshot version command generated the following package versions:
Tip: Use the snippet copy button below to quickly install the required packages. npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact
npm i @clerk/[email protected] --save-exact |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving, but I think it can be improved. If we merge before resolving the comments, let's follow up quickly after.
About the comments around experimental (if you agree) we should change the APIs before we merge since adding later would be breaking.
packages/clerk-js/src/ui/components/Checkout/CheckoutComplete.tsx
Outdated
Show resolved
Hide resolved
'@clerk/react-router': patch | ||
'@clerk/clerk-js': patch | ||
'@clerk/nextjs': patch | ||
'@clerk/clerk-react': patch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we are missing Astro
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its not merged #5774
packages/clerk-js/src/ui/components/Checkout/CheckoutComplete.tsx
Outdated
Show resolved
Hide resolved
…ckout-should-take-you-to-app-start
Description
Continue
within checkout complete component__experimental_checkoutContinueUrl
option that can override the afterSignInUrl navigationResolves COM-727
Checklist
pnpm test
runs as expected.pnpm build
runs as expected.Type of change